rendervulkan: ensure queue is idle before swapchain recreation #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CVulkanDevice::waitIdle call at the beginning of vulkan_remake_swapchain only waits for the most recently submitted command buffer to complete. This is inadequate because it does not wait for any additional commands which may have been submitted by the driver during vkQueuePresentKHR. Such commands could reference resources associated with the old swapchain, so it is not safe to destroy it until they are also complete. To fix the issue, instead of calling CVulkanDevice::waitIdle, vulkan_remake_swapchain will call vkQueueWaitIdle. Fixes: ValveSoftware#945
|
Merged manually to keep the cmdbuf reset behaviour. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CVulkanDevice::waitIdle call at the beginning of vulkan_remake_swapchain only waits for the most recently submitted command buffer to complete. This is inadequate because it does not wait for any additional commands which may have been submitted by the driver during vkQueuePresentKHR. Such commands could reference resources associated with the old swapchain, so it is not safe to destroy it until they are also complete.
To fix the issue, instead of calling CVulkanDevice::waitIdle, vulkan_remake_swapchain will call vkQueueWaitIdle.
Fixes: #945