Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix how the gamescope-reshade server clears effects #1524

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

wheaney
Copy link

@wheaney wheaney commented Sep 14, 2024

The current approach crashes when attempting to pass nullptr to effect path.

@wheaney
Copy link
Author

wheaney commented Sep 14, 2024

@Joshua-Ashton I've noticed that the reshade effects apply over steam elements just fine until I launch a game. When a game is running the effect applies well over the game but the steam menus seem to render to some overlay that doesn't get the effect. Do you have any insight into this? I'd love to fix so the effect always applies over all elements.

@misyltoad
Copy link
Collaborator

That is intentional, as we use it for HDR debugging primarily. The idea is that the game only has the effect if we ever wanted that on Deck fr more than debugging.

As for if you wanted to apply it to everything, it would be very possible to change the composition logic to do that in vulkan_composite, etc, but you would also miss out on being able to inline the reshade work with thegame's submissions.

@misyltoad misyltoad merged commit a2b45e1 into ValveSoftware:master Sep 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants