feat: Add Base support to Uniswap widget #619
Conversation
|
@abarthell is attempting to deploy a commit to the Uniswap Team on Vercel. A member of the Team first needs to authorize it. |
abarthell
force-pushed
the
add-base
branch
2 times, most recently
from
534f5f0
to
eb61652
Compare
abarthell
changed the title
abarthell
force-pushed
the
add-base
branch
7 times, most recently
from
c2bfa5d
to
e16253b
Compare
abarthell
force-pushed
the
add-base
branch
2 times, most recently
from
bf0710f
to
7b1e5aa
Compare
src/constants/chainInfo.ts
Outdated
| @@ -237,6 +238,19 @@ const CHAIN_INFO: ChainInfoMap = { | |||
| color: '#F0B90B', | |||
| backgroundColor: '#F0B90B', | |||
| }, | |||
| [SupportedChainId.BASE]: { | |||
| networkType: NetworkType.L2, | |||
| blockWaitMsBeforeWarning: ms`10m`, | |||
There was a problem hiding this comment.
It maybe worth making this match optimism:
blockWaitMsBeforeWarning: ms`25m`,
src/constants/jsonRpcEndpoints.ts
Outdated
| [SupportedChainId.BASE]: [ | ||
| // "Safe" URLs | ||
| 'https://mainnet.base.org', | ||
| 'https://developer-access-mainnet.base.org/', |
There was a problem hiding this comment.
Lets remove developer-access-mainnet.base.org, it resolves to the same hosts as mainnet.base.org and at some point we may remove it.
|
@abarthell assuming you were able to test locally, get quotes and execute trades - please mark this PR ready for review when you want us to review it ! |
@just-toby I don't think this PR will work until USDC on Base is added here (instead of USDbC). Should I also make a change there first? I wasn't sure if it'd cause some issue with the existing pool to just swap the contract address |
|
@abarthell that's a token constant in our |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -67,7 +67,7 @@ | |||
| "@uniswap/redux-multicall": "^1.1.8", | |||
| "@uniswap/router-sdk": "^1.6.0", | |||
| "@uniswap/sdk-core": "^4.0.6", | |||
| "@uniswap/smart-order-router": "^3.13.7", | |||
| "@uniswap/smart-order-router": "^3.16.25", | |||
There was a problem hiding this comment.
nice, i was about to comment but you found it 👍
| @@ -21,6 +21,8 @@ export enum SupportedChainId { | |||
| CELO_ALFAJORES = 44787, | |||
|
|
|||
| BNB = 56, | |||
|
|
|||
| BASE = 8453, | |||
There was a problem hiding this comment.
at some point our team might remove this enum entirely, like i started to do in #615 but for now this works
|
@abarthell please run |
@just-toby Sounds good! just ran deduplicate and also bumped the deps it was erroring on |
|
the test suite is only failing in your fork because you don't have the edit: i forgot the check is required. so we don't break protocol here, do you mind setting the env variable so we can re-run the tests and get all green ? :D |
@just-toby Ahh I see, good catch. I just set |
|
hmm @abarthell i think i was wrong and it's our repo that has the wrong value for this variable. i'll get it updated and make sure your PR gets merged. (might be tomorrow since i don't have permissions to edit the settings in this repo) |
|
@just-toby Can we try re-running it one more time? I think I had the wrong variable before actually |
|
@just-toby can you help upgrade the latest npm version of the widget as well? 😁 Also, here's two more PRs to add Base USDC on the interface (instead of USDbC) and the corresponding assets: |
Add Base support to Uniswap widget.
Tested swapping ETH to USDC on Base: https://basescan.org/tx/0xb230b5039555c3087b61906555b1b9495395cb60486b68f9871f791505429789