fix: type multicall usage #380
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zzmp
commented
Jan 12, 2023
| result: C['functions'][M] extends (...args: any) => Promise<infer T> ? T | undefined : never | ||
| } | ||
|
|
||
| type MultipleContractParams< |
There was a problem hiding this comment.
Note that *ContractParams is actually lossy, because it loses the names/documentation around the parameters and only retains their typing. Arguably, this should be explicit so that names are retained for a better devX. wdyt?
zzmp
commented
Jan 12, 2023
| import { useWeb3React } from '@web3-react/core' | ||
| import { Interface } from 'ethers/lib/utils' |
There was a problem hiding this comment.
This should be @ethersproject/contract-interfaces or something similar, not from the ethers umbrella package.
zzmp
commented
Jan 12, 2023
| @@ -8,9 +8,9 @@ import useIsArgentWallet from './useIsArgentWallet' | |||
| export function useArgentWalletContract(): ArgentWalletContract | null { | |||
There was a problem hiding this comment.
This type is now implied, and can be removed from the function definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typings for multicall hooks to improve multicall ergonomics and reduce the chance of misuse (eg ReferenceErrors).
Although functional, this is a POC - it is better to move this into redux-multicall itself so it can be useful for interface and other consumers as well.