put alt. calldata decoder back #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
changed the base branch from
better-calldata-checks
to
0age-calldata
hensha256
added a commit
that referenced
this pull request
Sep 6, 2024
* improved calldata checks * remove console * remove toLengthOffset function * natspec correction * mask values to be within 32 bits * verify array elements are encoded in order * mask straight after calldata load * masking in toBytes, remove selector constant * fuzz test * add testing * fix for 0 array length * put alt. calldata decoder back (#344) Co-authored-by: 0age <[email protected]> * core on main for debug profile * Fix length check * optimise toBytes * linting --------- Co-authored-by: 0age <[email protected]> Co-authored-by: 0age <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t @d1ll0n for the assistance
note that there's still a failing test that needs to be investigated here, but it should handle data overlaps