rename EPOCH_DEFAULT to EPOCH_NOT_INITIALIZED #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
reviewed
Jun 17, 2024
| @@ -159,7 +159,7 @@ contract LimitOrder is BaseHook { | |||
|
|
|||
| function _fillEpoch(PoolKey calldata key, int24 lower, bool zeroForOne) internal { | |||
| Epoch epoch = getEpoch(key, lower, zeroForOne); | |||
| if (!epoch.equals(EPOCH_DEFAULT)) { | |||
| if (!epoch.equals(EPOCH_NOT_INITIALIZED)) { | |||
There was a problem hiding this comment.
hmm i actually find this harder to read..
if epoch does not equal epoch not initialized ? its like double negative
maybe could you provide some more context/motivation for this name change?
There was a problem hiding this comment.
i feel like it makes the logic easier to follow. it emphasizes that there is nothing in that specific epoch. "default" feels confusing. maybe change the constant to EPOCH_EMPTY?
hensha256
reviewed
Jun 26, 2024
| @@ -57,7 +57,7 @@ contract LimitOrder is BaseHook { | |||
|
|
|||
| bytes internal constant ZERO_BYTES = bytes(""); | |||
|
|
|||
| Epoch private constant EPOCH_DEFAULT = Epoch.wrap(0); | |||
| Epoch private constant EPOCH_EMPTY = Epoch.wrap(0); | |||
There was a problem hiding this comment.
yeah i dont mind this - but i'd maybe go for ZERO_EPOCH? to match when we use things like ZERO_ADDRESS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
improves code clarity
Description of changes
rename EPOCH_DEFAULT to EPOCH_NOT_INITIALIZED in LimitOrder.sol