Skip to content

Commit

Permalink
typos
Browse files Browse the repository at this point in the history
  • Loading branch information
dianakocsis committed Aug 30, 2024
1 parent 6fd7e1f commit 4e12ba3
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/base/BaseActionsRouter.sol
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ abstract contract BaseActionsRouter is SafeCallback {
/// @notice function to handle the parsing and execution of an action and its parameters
function _handleAction(uint256 action, bytes calldata params) internal virtual;

/// @notice function that returns address considered executer of the actions
/// @notice function that returns address considered executor of the actions
/// @dev The other context functions, _msgData and _msgValue, are not supported by this contract
/// In many contracts this will be the address that calls the initial entry point that calls `_executeActions`
/// `msg.sender` shouldnt be used, as this will be the v4 pool manager contract that calls `unlockCallback`
Expand Down
4 changes: 2 additions & 2 deletions src/base/Notifier.sol
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ abstract contract Notifier is INotifier {
onlyIfApproved(msg.sender, tokenId)
onlyValidConfig(tokenId, config)
{
// will revert below if the user already has a subcriber
// will revert below if the user already has a subscriber
_positionConfigs(tokenId).setSubscribe();
ISubscriber _subscriber = subscriber[tokenId];

Expand All @@ -52,7 +52,7 @@ abstract contract Notifier is INotifier {
bool success = _call(newSubscriber, abi.encodeCall(ISubscriber.notifySubscribe, (tokenId, config, data)));

if (!success) {
Wrap__SubsciptionReverted.selector.bubbleUpAndRevertWith(newSubscriber);
Wrap__SubscriptionReverted.selector.bubbleUpAndRevertWith(newSubscriber);
}

emit Subscribed(tokenId, newSubscriber);
Expand Down
2 changes: 1 addition & 1 deletion src/interfaces/INotifier.sol
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {ISubscriber} from "./ISubscriber.sol";
/// @notice This interface is used to opt in to sending updates to external contracts about position modifications or transfers
interface INotifier {
/// @notice Wraps the revert message of the subscriber contract on a reverting subscription
error Wrap__SubsciptionReverted(address subscriber, bytes reason);
error Wrap__SubscriptionReverted(address subscriber, bytes reason);
/// @notice Wraps the revert message of the subscriber contract on a reverting modify liquidity notification
error Wrap__ModifyLiquidityNotificationReverted(address subscriber, bytes reason);
/// @notice Wraps the revert message of the subscriber contract on a reverting transfer notification
Expand Down
4 changes: 2 additions & 2 deletions src/lens/StateView.sol
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ contract StateView is ImmutableState {
}

/**
* @notice Retrieves total the liquidity of a pool.
* @notice Retrieves the total the liquidity of a pool.
* @dev Corresponds to pools[poolId].liquidity
* @param poolId The ID of the pool.
* @return liquidity The liquidity of the pool.
Expand Down Expand Up @@ -161,7 +161,7 @@ contract StateView is ImmutableState {

/**
* @notice Retrieves the liquidity of a position.
* @dev Corresponds to pools[poolId].positions[positionId].liquidity. More gas efficient for just retrieiving liquidity as compared to getPositionInfo
* @dev Corresponds to pools[poolId].positions[positionId].liquidity. More gas efficient for just retrieving liquidity as compared to getPositionInfo
* @param poolId The ID of the pool.
* @param positionId The ID of the position.
* @return liquidity The liquidity of the position.
Expand Down
2 changes: 1 addition & 1 deletion test/position-managers/PositionManager.notifier.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ contract PositionManagerNotifierTest is Test, PosmTestSetup, GasSnapshot {

vm.expectRevert(
abi.encodeWithSelector(
INotifier.Wrap__SubsciptionReverted.selector,
INotifier.Wrap__SubscriptionReverted.selector,
address(revertSubscriber),
abi.encodeWithSelector(MockRevertSubscriber.TestRevert.selector, "notifySubscribe")
)
Expand Down

0 comments on commit 4e12ba3

Please sign in to comment.