Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mistake in prismatic joint calculation #45

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

fangnan99
Copy link
Contributor

There is a mistake in the parallel Jacobian calculation for prismatic joints.

(Was mentioned in #3 but not fixed)

In jacobian.py, f.joint.axis.repeat(N, 1) result in shape (N,3) and cannot multiply with the (N,3,3) rotation matrix. Instead it should repeat(N,1,1) to get shape (N,1,3) to multiply with (N,3,3).

In frame.py, the expression theta * self.joint.axis is not permitted since the tensors have shapes (N,) and (3,). unsqueeze on theta solves it.

@LemonPi LemonPi merged commit a457cda into UM-ARM-Lab:master Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants