Add socket-related functions and wrappers, and a few other fixes. #2

Jimvy · 2018-09-24T15:50:01Z

This contains a lot of fixes and additions to CTester:

wrappers for socket-related functions, and associated unit tests;
utility functions related to sockets;
various corrections to the existing code;
splitting the run file to have the possibility to include CTester in a directory common to all other tasks;
and probably much more.

…d by POSIX standard

(Including wrap_getpid.c which was absent) Minor changes to student_code.h

The original code only made the reading end of the pipe non-blocking, as it needs to empty the pipe after the sandbox. But, if the student's program actually writes a lot on the writing end of the pipe, the pipe will block and cause the program to timeout. It is better to actually report this error (too much output) rather than waiting for the task to end. In both cases, the output will be truncated and it will not pass the tests, as we may expect the problem author to not require the student to output more than 65536 bytes or so of data on stdout or on stderr.

…bypass the tests. Also, makes sure to have a less undefined behaviour if the student actually calls exit: it will predictably raise a SIGSEGV instead of randomly not crashing instantly.

Functions: socket, bind, connect, accept, listen, recv (and al), send (and al). Currently only supports statistics Also included: Some unit tests

Not well-tested, however

…ng on stdout and stderr

…use by wrap_file and wrap_socket

…socket

- Remove write-related functions from read_write (currently not needed). - Add to run_ci the possibility of executing a single test. - A few corrections in read_write (time.h, NULL, const etc). - Allow exit to be called normally when the sandbox is not running.

Among these were incoherence between nanoseconds, microseconds and milliseconds, bad type for intervals, and something else. Functionnalities added include the possibility to create a read_buffer_t from the tables of offsets and intervals, when the data is contigous.

… monitored

…above 50%

The function allows to connect a UDP socket to a remote client. Also, a confusion has been fixed

Needs to be applied after read_write changes

- monitored.gai_strerror - memory leak when reset - missing implementations of setters of fai_report and check_fai - Fix simple_getaddrinfo so that it is more compliant to the true one - Add reset for all alternative methods

Jimvy · 2019-08-03T23:04:25Z

Sooo...

CNP3 exercises work perfectly as before (safe for an error in the grading code of the TCP exercise)
The task "strcpy" on LSINF1252 fails to compile due to errors in the test submissions that are caught by the new flags (-Wextra) ; submission 1
The task "advanced_queue" fails to compile due to a redefinition of the "stats" variable ; submissions 4, 5, 6, 9, 10, 11, 12, 13, 15
The task "order_relation_linked_list" fails too, for an unknown reason ; submission 3.
Aside from these, everything kind of works in local. A lot of bugs were fixed. Documentation was FINELY added.
Future todos:
Add more tests with real world task, like those on CNP3 - and add support in run_ci to recursively test the subfolders, and to execute a pre-test script
Investigate the limitations that are in doc/limitations.rst

Jimvy · 2019-08-27T00:51:56Z

FINALY.
The three tasks failed for the following reasons:

Addition of $(sort) to the SRC variable in the Makefile. The first item of the list changed from tests.c to student_code.c , and it causes problems with cppcheck, whose submissions are generally based on the mostly error-free tests.c
The default option --no-use-fifty, whereas all tasks used a 50% threshold.
Some compiler flags that were too aggressive: -Wextra and -Wshadow.
So, a temporary solution is to patch the files used for these 3 exercises.

Note that in the process of adding LSINF1252, it became possible to test for multiple subdirectories in ci/, but there may be some uncovered bugs.

mpiraux · 2019-09-10T08:47:21Z

Great! I don't know much about CTester itself, so I can't review every line of code you wrote, but the tests output give some confidence on the fact that nothing broke.

I think having the CI testing other courses from this repository is not the best option though. Don't get me wrong, having a CI testing a course is nice but it should not be CTester's CI. I think this repository should only contain self-contained tests, such as the ones you also added.
Could you move the courses testing part to the tested course repositories themselves ? Or is there something that I have missed that prevents you from doing so ?

mpiraux · 2019-09-10T12:47:30Z

.travis.yml


 before_install:
 - sudo apt-get install libcunit1 libcunit1-dev
+- pip3 install git+https://github.com/Maxmawt/INGInious # Until UCL-INGI/INGInious has fixed his part ;-)


Is this still needed ? Could you refer to a specific issue we should track on the INGInious repository ?

It was #414, but I don't know if it has been fixed since then. I'll check.

Jimvy added 30 commits July 9, 2018 17:34

Various corrections

e8b90ab

Some corrections

4bf0af0

Adding (hopefully sufficient) .gitignore

47b55fd

Replacing getpagesize() by getconf(_SC_PAGESIZE), which is recommande…

ca308e6

…d by POSIX standard

Adding include guards to prevent multiple inclusions

39dbe6e

Updating Makefile to include all C source in CTester/

65736a7

(Including wrap_getpid.c which was absent) Minor changes to student_code.h

Prevent SIGFPE from breaking the sandbox and the tests

4c2abc5

Removes temporarily the possibility for the student to call exit and …

be4ef7a

…bypass the tests. Also, makes sure to have a less undefined behaviour if the student actually calls exit: it will predictably raise a SIGSEGV instead of randomly not crashing instantly.

Updating Makefile

12258c9

Fixes unused parameters and shadowed declaration of variable i

43ade11

First version of DNS-related function wrappers

482e2f5

Update to DNS functions; it seems to work

633320d

Updating Makefile

29a4a70

Wrapper functions for socket and related functions

a19e302

Functions: socket, bind, connect, accept, listen, recv (and al), send (and al). Currently only supports statistics Also included: Some unit tests

Make CTester compile on CentOS

13d65e9

Add select, poll and byte-order functions

98c3073

Add delayed chunks to recv

3ec71e5

Not well-tested, however

Update run file to allow copying CTester from a external folder

1a321cd

Add fstdout and fstderr to allow tests to bypass the pipes when writi…

8df0a72

…ng on stdout and stderr

Reorganizing code of read and recv buffering and partial return, for …

f99a7ae

…use by wrap_file and wrap_socket

Add utility functions for inet and sockets

60a83ea

Renaming (well, copying) test_network_dns ro test_network_gai_simple_…

b279f35

…socket

Fix broken ci

f2c46e8

Add UDP support to util_sockets and fix a few errors

2b7d4d9

Remove write_buffer_t, as it is not yet available nor used

b0915a3

Add reinit_network_inet_stats

df4d54e

Add reinit_file_stats

7e0faab

Jimvy added 20 commits September 21, 2018 18:44

Rename set_read_buffer and add reinit functions for all stats and all…

73d4fb7

… monitored

Small fix to run file

6b1c968

Fix to run file: by default, do not give a sucess status if score is …

6fbb737

…above 50%

Remove useless fprintf

7633453

Add functions to get the number of bytes read from read_buffer

43c23a3

Correcting a few bugs by Valgrind and add a new function to utils-socket

d34f371

The function allows to connect a UDP socket to a remote client. Also, a confusion has been fixed

Merge branch 'master' of github.com:UCL-INGI/CTester

492e131

Preparing the PR

fa5ba4a

Update gitignore

acc0d8e

CTester.c: fix missing cleanup of read_write

49e4e20

Needs to be applied after read_write changes

Add real tests for DNS

8508162

Fix bugs in DNS wrappers

fb12d77

- monitored.gai_strerror - memory leak when reset - missing implementations of setters of fai_report and check_fai - Fix simple_getaddrinfo so that it is more compliant to the true one - Add reset for all alternative methods

Fix bug in sockets + member name changes for ptr arguments

eddc70a

Add init, cleanup methods for all mutex wrappers

8fa48fd

Move fd_is_read_buffered + clean whitespace

2d4d4f0

Add support for autotest (attempt)

080cc6f

Removing -pedantic as it clashes with RUN's void* and arithmetic

75be8f1

When copying CTester, don't overwrite existing files

c82b71a

Add documentation in source files, and license headers. Should be split.

7ddb2f6

Add Sphinx documentation

1642bbb

Jimvy added 4 commits August 21, 2019 18:43

Fix: copy CTester from /CTester alias /course/common/CTester/

ac11fb2

Add testing of compatibility with LSINF1252

6d9d6f2

Fix Travis

b1b229c

Fix Travis, again

98ee571

mpiraux reviewed Sep 10, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add socket-related functions and wrappers, and a few other fixes. #2

Add socket-related functions and wrappers, and a few other fixes. #2

Jimvy commented Sep 24, 2018

Jimvy commented Aug 3, 2019

Jimvy commented Aug 27, 2019

mpiraux commented Sep 10, 2019

mpiraux Sep 10, 2019

Jimvy Sep 10, 2019

Add socket-related functions and wrappers, and a few other fixes. #2

Are you sure you want to change the base?

Add socket-related functions and wrappers, and a few other fixes. #2

Conversation

Jimvy commented Sep 24, 2018

Jimvy commented Aug 3, 2019

Jimvy commented Aug 27, 2019

mpiraux commented Sep 10, 2019

mpiraux Sep 10, 2019

Choose a reason for hiding this comment

Jimvy Sep 10, 2019

Choose a reason for hiding this comment