Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Turing to v0.34 #513

Merged
merged 6 commits into from
Sep 2, 2024
Merged

Update Turing to v0.34 #513

merged 6 commits into from
Sep 2, 2024

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Aug 30, 2024

This PR follows on from the release of v0.34.0: https://github.com/TuringLang/Turing.jl/releases/tag/v0.34.0

  • It also includes some small textual improvements to the Contributing page
  • I've also made a new branch, backport-v0.33, with the current contents of master, so that the v0.33 docs get published as well.

Copy link
Contributor

Preview the changes: https://turinglang.org/docs/pr-previews/513
Please avoid using the search feature and navigation bar in PR previews!

Comment on lines +11 to +12
Our outstanding issues are tabulated on our [issue tracker](https://github.com/TuringLang/Turing.jl/issues).
Closing one of these may involve implementing new features, fixing bugs, or writing example models.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things here which I think it might be worth thinking about:

  1. Turing issues aren't all hosted on Turing.jl, they're scattered around the entire organisation. I don't know if there's a way to view all of them at the same time.

  2. If someone wants to work on an issue, it would be good for at least one of us to be aware of that. It's probably a bit intimidating for someone new to directly ping a person, and in any case the person that is pinged might not see it because they're away etc.

    I think it would be good to create an organisation team like @turinglang/maintainers or something like that, and say "if you want to take on an open issue, ping this group of people". Then one of us could (for example) assign the issue to them. (This is a pattern I've seen on other projects.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to experiment with it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea of maintainers team.

Also, if you have any ideas for how to keep tabs on what's going on in the repo, I'm looking for better ways. I would ideally like an email notification every time a new issue or PR is opened, but not every time a comment is left in any issue or PR, and I haven't found a way to do it. Either I get unmanageable amounts of spam, or I miss out on important conversations and changes.

Could discuss this at one of the weekly catch-ups.

@yebai
Copy link
Member

yebai commented Sep 1, 2024

Thanks, @penelopeysm; this looks good!

Can we add an Action to the Turing.jl repo to automate this for future releases?

@yebai yebai requested a review from mhauru September 1, 2024 08:36
Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a few very minor suggestions.

How do the backport branches work?

tutorials/docs-01-contributing-guide/index.qmd Outdated Show resolved Hide resolved
tutorials/docs-01-contributing-guide/index.qmd Outdated Show resolved Hide resolved
tutorials/docs-01-contributing-guide/index.qmd Outdated Show resolved Hide resolved
Comment on lines +11 to +12
Our outstanding issues are tabulated on our [issue tracker](https://github.com/TuringLang/Turing.jl/issues).
Closing one of these may involve implementing new features, fixing bugs, or writing example models.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea of maintainers team.

Also, if you have any ideas for how to keep tabs on what's going on in the repo, I'm looking for better ways. I would ideally like an email notification every time a new issue or PR is opened, but not every time a comment is left in any issue or PR, and I haven't found a way to do it. Either I get unmanageable amounts of spam, or I miss out on important conversations and changes.

Could discuss this at one of the weekly catch-ups.

@penelopeysm
Copy link
Member Author

penelopeysm commented Sep 2, 2024

Thanks both.

@yebai Yes! I think I can make a workflow on Turing.jl to open an issue on this repo when there's a new release of Turing.jl. (Making a PR would require us to feed it another token) Opening an issue also needs a token. Not a fan of it. Will think about other ways of coordinating this.

@mhauru backport-vX.Y branches are deployed to /versions/vX.Y on GitHub Pages, so creating this branch gives us https://turinglang.org/docs/versions/v0.33.3/.

The list of versions should then point to it. However, the list of versions is only generated when this is merged into master, so I can't verify that it works now ... but it should.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks @penelopeysm!

@penelopeysm penelopeysm merged commit ef4165e into master Sep 2, 2024
4 checks passed
@penelopeysm penelopeysm deleted the pysm/v0.34 branch September 2, 2024 16:02
github-actions bot added a commit that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants