Merge `libtask_ext` upstream #2115

FredericWantiez · 2023-11-02T18:58:14Z

Close #2119; Close #2120; Close #2121; Close #2122; Close #2123; Close #2124; Close #2125; Close #2126; Close #2127; Close #2128

Breaking change: resume_from has been unified with initial_state; the resume export is removed.

Project.toml

Co-authored-by: Hong Ge <[email protected]>

FredericWantiez · 2023-11-04T11:41:08Z

Need to change a few things since we changed the signature of sweep! in between, looks like my master was out of sync.

'

github-actions · 2023-11-05T01:27:47Z

Pull Request Test Coverage Report for Build 6828915297

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

0 of 14 (0.0%) changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage	Changed/Added Lines	%
src/mcmc/hmc.jl	1	0.0%
src/essential/container.jl	3	0.0%
src/mcmc/Inference.jl	4	0.0%
src/mcmc/particle_mcmc.jl	6	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/mcmc/particle_mcmc.jl	1	0.0%

Totals
Change from base Build 6732566276:	0.0%
Covered Lines:	0
Relevant Lines:	1435

💛 - Coveralls

codecov · 2023-11-05T01:27:53Z

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (4ffe2cd) 0.00% compared to head (55ca37f) 0.00%.
Report is 2 commits behind head on master.

❗ Current head 55ca37f differs from pull request most recent head b7758be. Consider uploading reports for the commit b7758be to get more accurate results

Additional details and impacted files

@@          Coverage Diff           @@
##           master   #2115   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          21      21           
  Lines        1451    1450    -1     
======================================
+ Misses       1451    1450    -1

Files	Coverage Δ
src/mcmc/Inference.jl	`0.00% <0.00%> (ø)`
src/mcmc/abstractmcmc.jl	`0.00% <0.00%> (ø)`
src/mcmc/particle_mcmc.jl	`0.00% <0.00%> (ø)`
src/essential/container.jl	`0.00% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

FredericWantiez · 2023-11-05T10:26:58Z

I can add a few more tests if needed

yebai · 2023-11-05T15:25:43Z

@FredericWantiez sounds good to have a few additional tests.

test/essential/container.jl

src/essential/container.jl

yebai · 2023-11-07T12:26:16Z

Thanks @FredericWantiez -- good work. I left two minor suggestions above.

Re styling: is there a reason for using the 8-space tab in this PR?

FredericWantiez · 2023-11-07T20:49:30Z

re: styling. Looks like the IDE messed up everything, I'll change

…t) (#2108) * CompatHelper: bump compat for AbstractMCMC to 5, (keep existing compat) * Update Project.toml * CompatHelper: bump compat for AbstractMCMC to 5 for package test, (keep existing compat) (#2109) Co-authored-by: CompatHelper Julia <[email protected]> * Update Project.toml * CompatHelper: bump compat for AdvancedHMC to 0.6, (keep existing compat) (#2116) * CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat) (#2112) * CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat) * Update Project.toml --------- Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Hong Ge <[email protected]> * CompatHelper: bump compat for AdvancedHMC to 0.6, (keep existing compat) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Hong Ge <[email protected]> * CompatHelper: bump compat for EllipticalSliceSampling to 2, (keep existing compat) (#2110) Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Hong Ge <[email protected]> * CompatHelper: bump compat for AdvancedMH to 0.8 for package test, (keep existing compat) (#2114) Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Hong Ge <[email protected]> * CompatHelper: bump compat for AdvancedMH to 0.8, (keep existing compat) (#2113) Co-authored-by: CompatHelper Julia <[email protected]> --------- Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: Hong Ge <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Project.toml

yebai · 2023-11-10T12:05:18Z

We need to unify the resume_from/initial_state interface due to TuringLang/DynamicPPL.jl#551

src/mcmc/hmc.jl

src/mcmc/particle_mcmc.jl

FredericWantiez added 2 commits October 30, 2023 22:36

Test

8070edf

Fix most of the issues ?

4221df9

yebai reviewed Nov 3, 2023

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

FredericWantiez and others added 3 commits November 3, 2023 20:55

Update Project.toml

0fbc87b

Co-authored-by: Hong Ge <[email protected]>

Merge branch 'master' into fred/libtask_ext

8e45bfd

Update Project.toml

209e23d

FredericWantiez added 2 commits November 4, 2023 21:27

Pass sampler argument

712137e

Bump advancedPS'

287d7bb

'

FredericWantiez marked this pull request as ready for review November 5, 2023 10:01

FredericWantiez changed the title ~~[WIP] Merge libtask_ext upstream~~ Merge libtask_ext upstream Nov 5, 2023

FredericWantiez added 3 commits November 6, 2023 21:34

Add tests

ac6ffcc

Imports

b440086

Catch replaying mechanism, wish I had this one earlier

6a361ab

yebai reviewed Nov 7, 2023

View reviewed changes

test/essential/container.jl Show resolved Hide resolved

yebai reviewed Nov 7, 2023

View reviewed changes

src/essential/container.jl Outdated Show resolved Hide resolved

Update Project.toml

3d6f2b3

FredericWantiez added 2 commits November 7, 2023 20:56

Fix tabs

55ca37f

No need for deepcopy

1b75586

FredericWantiez mentioned this pull request Nov 8, 2023

Deepcopy model in LibtaskModel TuringLang/AdvancedPS.jl#92

Merged

yebai reviewed Nov 9, 2023

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

Update Project.toml

ee4a841

yebai added 2 commits November 10, 2023 16:48

fix resume_from

4c3c391

unify resume and initial_state

77660e5

yebai approved these changes Nov 10, 2023

View reviewed changes

src/mcmc/hmc.jl Outdated Show resolved Hide resolved

src/mcmc/particle_mcmc.jl Outdated Show resolved Hide resolved

yebai and others added 3 commits November 10, 2023 17:17

Apply suggestions from code review

c3ce83a

remove resume export

26dcf83

fix resume for prior sampler

5faeaab

yebai force-pushed the fred/libtask_ext branch from d90f49c to 5faeaab Compare November 10, 2023 18:26

fix default_chain_type for prior sampler

b7758be

yebai merged commit d4a7975 into master Nov 10, 2023
6 of 11 checks passed

yebai deleted the fred/libtask_ext branch November 10, 2023 21:05

This was referenced Jan 7, 2024

init_params doesn't work since v0.30.0 #2150

Closed

Fix AbstractMCMC 5 compatibility #2153

Merged

torfjelde mentioned this pull request Apr 10, 2024

Do we need resume_from now that we have initial_state? #2171

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge `libtask_ext` upstream #2115

Merge `libtask_ext` upstream #2115

FredericWantiez commented Nov 2, 2023 •

edited by yebai

Loading

FredericWantiez commented Nov 4, 2023

github-actions bot commented Nov 5, 2023 •

edited

Loading

codecov bot commented Nov 5, 2023 •

edited

Loading

FredericWantiez commented Nov 5, 2023

yebai commented Nov 5, 2023

yebai commented Nov 7, 2023 •

edited

Loading

FredericWantiez commented Nov 7, 2023 •

edited

Loading

yebai commented Nov 10, 2023 •

edited

Loading

Merge libtask_ext upstream #2115

Merge libtask_ext upstream #2115

Conversation

FredericWantiez commented Nov 2, 2023 • edited by yebai Loading

FredericWantiez commented Nov 4, 2023

github-actions bot commented Nov 5, 2023 • edited Loading

Pull Request Test Coverage Report for Build 6828915297

Warning: This coverage report may be inaccurate.

💛 - Coveralls

codecov bot commented Nov 5, 2023 • edited Loading

Codecov Report

FredericWantiez commented Nov 5, 2023

yebai commented Nov 5, 2023

yebai commented Nov 7, 2023 • edited Loading

FredericWantiez commented Nov 7, 2023 • edited Loading

yebai commented Nov 10, 2023 • edited Loading

Merge `libtask_ext` upstream #2115

Merge `libtask_ext` upstream #2115

FredericWantiez commented Nov 2, 2023 •

edited by yebai

Loading

github-actions bot commented Nov 5, 2023 •

edited

Loading

codecov bot commented Nov 5, 2023 •

edited

Loading

yebai commented Nov 7, 2023 •

edited

Loading

FredericWantiez commented Nov 7, 2023 •

edited

Loading

yebai commented Nov 10, 2023 •

edited

Loading