Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zygote pullback depwarning #657

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Sep 9, 2024

Zygote kept saying this:

┌ Warning: Incorrect argument order for pullback, please use:
│ 
│   pullback(f, __context__::Context, args)
│ 
│ instead of:
│ 
│   pullback(__context__::Context, f, args)
│ 
│ This is usually caused by a call to pullback in a higher-order @adjoint.
│ The above warning will become an error in Zygote 0.7.
└ @ Zygote ~/.julia/packages/Zygote/nsBv0/src/compiler/interface.jl:95

@mhauru mhauru requested a review from sunxd3 September 9, 2024 16:33
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10777382418

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.6%) to 75.952%

Totals Coverage Status
Change from base Build 10701838580: -1.6%
Covered Lines: 2672
Relevant Lines: 3518

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10777382418

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 77.508%

Totals Coverage Status
Change from base Build 10701838580: 0.0%
Covered Lines: 2712
Relevant Lines: 3499

💛 - Coveralls

@yebai
Copy link
Member

yebai commented Sep 13, 2024

Thanks @mhauru!

@yebai yebai added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit 24a7380 Sep 13, 2024
11 of 12 checks passed
@yebai yebai deleted the mhauru/zygote-pullback-arg-order branch September 13, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants