Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ZygoteRules and ChainRulesCore weak dependencies #564

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Make ZygoteRules and ChainRulesCore weak dependencies #564

merged 5 commits into from
Nov 21, 2023

Conversation

devmotion
Copy link
Member

IMO these overloads in the compat subfolder are natural candidates for a weak dependency.

@TuringLang TuringLang deleted a comment from github-actions bot Nov 21, 2023
@TuringLang TuringLang deleted a comment from github-actions bot Nov 21, 2023
@TuringLang TuringLang deleted a comment from github-actions bot Nov 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6947129998

  • 7 of 8 (87.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 81.55%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ext/DynamicPPLZygoteRulesExt.jl 4 5 80.0%
Totals Coverage Status
Change from base Build 6947084016: 1.3%
Covered Lines: 2568
Relevant Lines: 3149
💛 - Coveralls

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (03e4ba2) 80.26% compared to head (b28f6bb) 81.00%.

Files Patch % Lines
ext/DynamicPPLZygoteRulesExt.jl 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
+ Coverage   80.26%   81.00%   +0.74%     
==========================================
  Files          26       26              
  Lines        3167     3170       +3     
==========================================
+ Hits         2542     2568      +26     
+ Misses        625      602      -23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

torfjelde
torfjelde approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@torfjelde torfjelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One thing though: do we know why compat is complaining? Or is codecov only run on Julia 1.9?

@devmotion
Copy link
Member Author

Coverage analysis was only performed on Julia 1.9.

@devmotion
Copy link
Member Author

Good to go, @torfjelde?

@torfjelde
Copy link
Member

Aye:)

@devmotion devmotion added this pull request to the merge queue Nov 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 21, 2023
@devmotion devmotion added this pull request to the merge queue Nov 21, 2023
Merged via the queue into master with commit fc6cae9 Nov 21, 2023
13 of 14 checks passed
@devmotion devmotion deleted the dw/zygoterules_chainrulescore branch November 21, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torfjelde torfjelde torfjelde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devmotion @torfjelde