operation-id and tag

Tufin · Sep 7, 2024 · 7a89f47 · 7a89f47
1 parent 407ad51
commit 7a89f47
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 7 deletions.
diff --git a/checker/generator/data.go b/checker/generator/data.go
@@ -62,8 +62,8 @@ var endpointValueSets = ValueSets{
 	},
 	ValueSetA{
 		nouns:   []string{"api path", "api"},
-		actions: []string{"add", "remove"},
-		adverb:  "without deprecation",
+		actions: []string{"remove"},
+		adverb:  []string{"without deprecation", "before sunset"},
 	},
 	ValueSetB{
 		nouns:   []string{"endpoint"}, // /Paths/PathItem
@@ -74,6 +74,15 @@ var endpointValueSets = ValueSets{
 		nouns:                []string{"success response status", "non-success response status"}, // /Paths/PathItem/Operation/Responses/Response/content/media-type/
 		actions:              []string{"add", "remove"},
 	},
+	ValueSetA{
+		nouns:   []string{"operation id"},
+		actions: []string{"change"},
+	},
+	ValueSetB{
+		predicativeAdjective: "%s",
+		nouns:                []string{"operation id", "tag"},
+		actions:              []string{"add", "remove"},
+	},
 	ValueSetB{
 		predicativeAdjective: "%s",
 		hierarchy:            []string{"endpoint security scheme"},

diff --git a/checker/generator/messages.yaml b/checker/generator/messages.yaml
@@ -1,8 +1,8 @@
 stability-decreased: stability was decreased from %s to %s
-api-path-added: api path was added without deprecation
 api-path-removed: api path was removed without deprecation
-api-added: api was added without deprecation
+api-path-removed: api path was removed before sunset
 api-removed: api was removed without deprecation
+api-removed: api was removed before sunset
 endpoint-added: added endpoint
 endpoint-removed: removed endpoint
 endpoint-deprecated: deprecated endpoint
@@ -11,6 +11,11 @@ success-response-status-added: added success response status %s
 success-response-status-removed: removed success response status %s
 non-success-response-status-added: added non-success response status %s
 non-success-response-status-removed: removed non-success response status %s
+operation-id-changed: operation id was changed from %s to %s
+operation-id-added: added operation id %s
+operation-id-removed: removed operation id %s
+tag-added: added tag %s
+tag-removed: removed tag %s
 endpoint-security-scheme-security-scope-added: added security scope %s to endpoint security scheme %s
 endpoint-security-scheme-security-scope-removed: removed security scope %s from endpoint security scheme %s
 request-body-media-type-max-set: max value of media-type %s of request body was set to %s

diff --git a/checker/generator/value_set.go b/checker/generator/value_set.go
@@ -37,7 +37,7 @@ type ValueSet struct {
 	hierarchy            []string
 	nouns                []string
 	actions              []string
-	adverb               string
+	adverb               []string
 }
 
 func (v ValueSet) setHierarchy(hierarchy []string) ValueSet {
@@ -70,8 +70,15 @@ func (v ValueSetA) generate(out io.Writer) {
 	for _, noun := range v.nouns {
 		for _, action := range v.actions {
 			id := generateId(v.hierarchy, noun, action)
-			message := generateMessage(v.hierarchy, noun, v.attributiveAdjective, v.predicativeAdjective, action, v.adverb)
-			fmt.Fprintln(out, fmt.Sprintf("%s: %s", id, message))
+
+			adverbs := v.adverb
+			if v.adverb == nil {
+				adverbs = []string{""}
+			}
+			for _, adverb := range adverbs {
+				message := generateMessage(v.hierarchy, noun, v.attributiveAdjective, v.predicativeAdjective, action, adverb)
+				fmt.Fprintln(out, fmt.Sprintf("%s: %s", id, message))
+			}
 		}
 	}
 }