Skip to content

Commit

Permalink
more media-types
Browse files Browse the repository at this point in the history
  • Loading branch information
reuvenharrison committed Aug 29, 2024
1 parent 33d8c79 commit 27508f2
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions checker/check_request_property_became_enum.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func RequestPropertyBecameEnumCheck(diffReport *diff.Diff, operationsSources *di
continue
}
modifiedMediaTypes := operationItem.RequestBodyDiff.ContentDiff.MediaTypeModified
for _, mediaTypeDiff := range modifiedMediaTypes {
for mediaType, mediaTypeDiff := range modifiedMediaTypes {
if mediaTypeDiff.SchemaDiff == nil {
continue
}
Expand All @@ -41,7 +41,7 @@ func RequestPropertyBecameEnumCheck(diffReport *diff.Diff, operationsSources *di
result = append(result, NewApiChange(
RequestPropertyBecameEnumId,
config,
[]any{propertyFullName(propertyPath, propertyName)},
[]any{propertyFullName(propertyPath, propertyName), mediaType},
"",
operationsSources,
operationItem.Revision,
Expand Down
10 changes: 5 additions & 5 deletions checker/check_request_property_updated.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ func RequestPropertyUpdatedCheck(diffReport *diff.Diff, operationsSources *diff.
continue
}
modifiedMediaTypes := operationItem.RequestBodyDiff.ContentDiff.MediaTypeModified
for _, mediaTypeDiff := range modifiedMediaTypes {
for mediaType, mediaTypeDiff := range modifiedMediaTypes {
CheckDeletedPropertiesDiff(
mediaTypeDiff.SchemaDiff,
func(propertyPath string, propertyName string, propertyItem *openapi3.Schema, parent *diff.SchemaDiff) {
Expand All @@ -38,7 +38,7 @@ func RequestPropertyUpdatedCheck(diffReport *diff.Diff, operationsSources *diff.
result = append(result, NewApiChange(
RequestPropertyRemovedId,
config,
[]any{propertyFullName(propertyPath, propertyName)},
[]any{propertyFullName(propertyPath, propertyName), mediaType},
"",
operationsSources,
operationItem.Revision,
Expand All @@ -61,7 +61,7 @@ func RequestPropertyUpdatedCheck(diffReport *diff.Diff, operationsSources *diff.
result = append(result, NewApiChange(
NewRequiredRequestPropertyId,
config,
[]any{propName},
[]any{propName, mediaType},
"",
operationsSources,
operationItem.Revision,
Expand All @@ -72,7 +72,7 @@ func RequestPropertyUpdatedCheck(diffReport *diff.Diff, operationsSources *diff.
result = append(result, NewApiChange(
NewRequiredRequestPropertyWithDefaultId,
config,
[]any{propName},
[]any{propName, mediaType},
"",
operationsSources,
operationItem.Revision,
Expand All @@ -84,7 +84,7 @@ func RequestPropertyUpdatedCheck(diffReport *diff.Diff, operationsSources *diff.
result = append(result, NewApiChange(
NewOptionalRequestPropertyId,
config,
[]any{propName},
[]any{propName, mediaType},
"",
operationsSources,
operationItem.Revision,
Expand Down
6 changes: 3 additions & 3 deletions checker/localizations/localizations.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions checker/localizations_src/en/messages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ sunset-deleted: api sunset date deleted, but deprecated=true kept
api-sunset-date-changed-too-small: api sunset date changed to earlier date from %s to %s, new sunset date must be not earlier than %s at least %s days from now
new-required-request-parameter: added required %s request parameter %s
new-optional-request-parameter: added optional %s request parameter %s
new-required-request-property: added required request property %s
new-required-request-property: added required request property %s to media-type %s
new-required-request-property-with-default: added required request property %s with a default value to media-type %s
new-optional-request-property: added optional request property %s
new-optional-request-property: added optional request property %s to media-type %s
new-required-request-header-property: added required %s request header's property %s
request-body-became-required: request body became required
request-body-became-optional: request body became optional
Expand Down

0 comments on commit 27508f2

Please sign in to comment.