Add patch to replace hexdump with od #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmcd
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
1.) Make sure you get @bahamat 's signoff before pushing.
2.) I hope the dehydrated-io/dehydrated#910 suggestion of clever use of od(1) in a pipe will cure this permanently upstream.
bahamat
requested changes
Aug 6, 2024
bahamat
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Ok, I've sunk some time into this today. I have a proposed patch in dehydrated-io/dehydrated#943, so I'd prefer to use that instead.
You can pull that patch in here even if it doesn't land upstream.
Apply patch early dehydrated-io/dehydrated#943 Fixes #65
teutat3s
force-pushed
the
fix-hexdump-check
branch
from
03eec97
to
8303351
Compare
|
Done in 8303351. |
teutat3s
changed the title
bahamat
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hexdumpbinary is only required when using ZeroSSL as CA. This patch moves the check to the according function, unbreaking the script for Let's Encrypt CA.Fixes #65. Tested script works on SmartOS with this change and Let's Encrypt as CA.