Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pulumi): Support --yes and --skipPreview options #143

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

ffMathy
Copy link
Contributor

@ffMathy ffMathy commented Aug 23, 2023

Fixes #142.

Marked as draft, as I am not sure how to test it. If you think it's okay to merge without testing, let me know.

@nx-cloud
Copy link

nx-cloud bot commented Aug 23, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit facade9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@TriPSs
Copy link
Owner

TriPSs commented Aug 23, 2023

Thanks for the PR, looks good as is.

One thing, please do use conventional commits as these changes (like the previous) will now not show up the changelog.

@ffMathy
Copy link
Contributor Author

ffMathy commented Aug 23, 2023

Interesting. What are "conventional commits"? Never heard of that before actually.

@TriPSs
Copy link
Owner

TriPSs commented Aug 23, 2023

I see I'm also missing the contributing here 😅, here you can find more info: https://www.conventionalcommits.org/en/v1.0.0/

@ffMathy
Copy link
Contributor Author

ffMathy commented Aug 23, 2023

Oh, interesting! That's cool. I'll definitely start using that myself. What can we do about the existing commits though? I'm not a GIT mastermind.

Perhaps we could squash the pull request when we merge it, and then set a commit message there?

@ffMathy ffMathy marked this pull request as ready for review August 23, 2023 12:42
@TriPSs
Copy link
Owner

TriPSs commented Aug 23, 2023

Yea, we can update the PR name that will also work, good one.

@ffMathy ffMathy changed the title Add support for Pulumi options feat: add support for "yes" and "skipPreview" command-line arguments Aug 23, 2023
@TriPSs TriPSs changed the title feat: add support for "yes" and "skipPreview" command-line arguments feat(pulumi): Support --yes and --skipPreview options Aug 23, 2023
@TriPSs TriPSs merged commit 0b6c7f9 into TriPSs:master Aug 23, 2023
2 checks passed
@ffMathy
Copy link
Contributor Author

ffMathy commented Aug 23, 2023

Ah, didn't see the parenthes stuff in the spec. Thanks for renaming it ❤️

@ffMathy ffMathy deleted the master-1 branch August 23, 2023 12:44
@TriPSs
Copy link
Owner

TriPSs commented Aug 23, 2023

Yes that's the scope, I always put the package name in it. Thanks for the PR!

@TriPSs
Copy link
Owner

TriPSs commented Aug 23, 2023

Bit of a shame that the changelog still did not pick it up 😅 Maybe it has to do with the fact that it was a merge commit 🤔

@ffMathy
Copy link
Contributor Author

ffMathy commented Aug 23, 2023

Yeah maybe it should have been a squash. Hard to tell.

Thanks for teaching me about conventional commits though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulumi: Running up with --yes or --skip-preview
2 participants