Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various editor and UI improvements #151

Open
wants to merge 15 commits into
base: dev
Choose a base branch
from
Open

Various editor and UI improvements #151

wants to merge 15 commits into from
+915 −333

Conversation

PurkkaKoodari
Copy link
Member

@PurkkaKoodari PurkkaKoodari commented Sep 21, 2024 •
edited
Loading

This PR fixes many current annoyances and adds some features we can add without changing the (effective) DB or API schema. (There are some API changes, but they only limit requests that would've failed anyway under previous code.)

  • Closes Improve editor validation #32: the editor now validates the event and shows immediate feedback for errors
    • Also validates some things not properly validated by the TypeBox schema or even backend
    • maxLengths added to various fields, so that the user can't even input invalid data
      image
  • Closes Add option to preview events as admin #64: admins can now preview events from the editor, including the signup form
    image
  • Signup start/end time and signup publicity are now part of "basic details", to make the experience less confusing
  • Added a price field to the editor (the schema already supported this)
  • Signup closure date is now shown in event list & event details when the signup is closed
  • Quota size fields now have placeholders to indicate what empty means
  • Quota name is no longer shown in signup lists when there's only one
  • TypeBox schemas updated to use Composite, and they now validate more invariants (instead of failing at database level)
  • Various bug fixes to the editor and other UI

@PurkkaKoodari
feat: add event preview to editor (#64)
4ebc0c5
@PurkkaKoodari
feat: move non-quota fields out of QuotasTab
8272988
@PurkkaKoodari
fix: reduce form label hitboxes to text size
ea402ad
@PurkkaKoodari
fix: hide slug status when no slug is inputted
1ed07b3
@PurkkaKoodari
refactor: update TypeBox schemas
c9779b6 
- Add validation constraints to match most Sequelize constraints
- Replace Intersect() with Composite() from TypeBox 0.26 for nicer schemas
- Improve naming
@PurkkaKoodari
fix: allow event title wrapping
7b60783
@PurkkaKoodari
feat: add maxLengths to Editor, improve typing
094a83b
@PurkkaKoodari
chore: allow for..of, we're now building ES6
2e2ed36
@PurkkaKoodari
feat: add editor validation and price field
0975d0c 
- Add schema validation to Editor using Zod
- Add error formatting to FieldRow
- Add price field to Editor (support was everywhere else already)
- Unify these changes to EditSignup
@PurkkaKoodari
feat: add placeholders to quota size fields
c400460
@PurkkaKoodari
feat: show closure date for closed signups
00f36db
@PurkkaKoodari
feat: hide name of only quota in open/queue
9483969
@PurkkaKoodari PurkkaKoodari changed the title Various editor improvements Various editor and UI improvements Sep 22, 2024
@PurkkaKoodari PurkkaKoodari marked this pull request as ready for review September 22, 2024 21:19
@PurkkaKoodari PurkkaKoodari requested a review from a team September 22, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to preview events as admin Improve editor validation
1 participant
@PurkkaKoodari