Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMX TCR Updates #806

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

PMX TCR Updates #806

wants to merge 10 commits into from

Conversation

sjackle
Copy link

@sjackle sjackle commented Jul 23, 2024

Summary

Corrected a problem with the PMX TCR Codec
Added our LoRa Alliance Vendor ID

...

Changes

  • ...
  • ...

Checklist for Reviewers

  • Title and description should be descriptive (Not just a serial number for example).
  • profileIDs should not be vendorID and should be a unique value for every profile.
  • All devices should be listed in the vendor's index.yaml file.
  • Firmware versions can not be changed.
  • At least 1 image per device and should be transparent.

Notes for Reviewers

...

Release Notes

  • ...

@Jaime-Trinidad
Copy link
Contributor

HI @sjackle please run make validate fmt and update the branch so I can merge it. Thanks

@sjackle
Copy link
Author

sjackle commented Sep 2, 2024

Hi Jaime
What is missing here?

@LDannijs
Copy link
Contributor

LDannijs commented Sep 3, 2024

@sjackle Please still run make validate fmt and update the branch if needed.

@Jaime-Trinidad
Copy link
Contributor

Hi @sjackle please update the branch so I can merge it. Thanks

@sjackle
Copy link
Author

sjackle commented Sep 24, 2024

Hi @sjackle please update the branch so I can merge it. Thanks

Done. Updated branch, tested my entry and make validate fmt executed w/o issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants