Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #32

Merged
merged 22 commits into from
Apr 18, 2020
Merged

Fix CI #32

merged 22 commits into from
Apr 18, 2020

Conversation

cbachhuber
Copy link
Contributor

@cbachhuber cbachhuber commented Apr 17, 2020

Addressing #31:

  • Link dogm privately against glew and related libraries
  • Re-create deleted build folder (only during compilation in CI), as suggested by @TheCodez
  • Tidy up CI instructions (this is according to my taste, feel free to suggest changes)

@TheCodez
Copy link
Owner

This introduced some small CMake errors on windows. Will report back once I fixed them.

@TheCodez
Copy link
Owner

Could you please change line 20 in CMakelists.txt to

if (NOT WIN32)
	find_package(GLEW)
endif()

I will try to automate the dependency searching on Windows in the future.

@TheCodez
Copy link
Owner

Now it can't find <glm/vec4.hpp> when compiling, nice 😀

dogm/CMakeLists.txt Outdated Show resolved Hide resolved
@cbachhuber
Copy link
Contributor Author

cbachhuber commented Apr 18, 2020

I implemented both your suggestions. Does that fix the Windows build?

CI is still green 👍

@@ -1,6 +1,6 @@
name: C/C++ CI

on: [push]
on: [push, pull_request]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@TheCodez
Copy link
Owner

Yes, thank you!

@TheCodez TheCodez merged commit 231d0e5 into TheCodez:master Apr 18, 2020
@cbachhuber cbachhuber deleted the fix-ci branch April 22, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants