-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #32
Fix CI #32
Conversation
This reverts commit 148e408.
This introduced some small CMake errors on windows. Will report back once I fixed them. |
Could you please change line 20 in CMakelists.txt to
I will try to automate the dependency searching on Windows in the future. |
Now it can't find |
I implemented both your suggestions. Does that fix the Windows build? CI is still green 👍 |
@@ -1,6 +1,6 @@ | |||
name: C/C++ CI | |||
|
|||
on: [push] | |||
on: [push, pull_request] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
Yes, thank you! |
Addressing #31: