Skip to content

Commit

Permalink
server: Add equals operator in mpv options (#49)
Browse files Browse the repository at this point in the history 
Following mpv-player/mpv@d3cef97, all options passed to mpv require
the format "mpv --o='path'" instead of "mpv --o 'path'". This change
should be backwards compatible with older mpv versions as well.
  • Loading branch information
@NotTsunami @TheAMM
NotTsunami authored and TheAMM committed Jan 16, 2020
1 parent e0225de commit 682becf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/thumbnailer_server.lua
View file
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function create_thumbnail_mpv(file_path, timestamp, size, output_path, options)
"--vf-add=format=bgra",
"--of=rawvideo",
"--ovc=rawvideo",
"--o", output_path
"--o=" .. output_path
})
return utils.subprocess({args=mpv_command})
end
Expand Down

5 comments on commit 682becf

@StacktraceException
Copy link

@StacktraceException StacktraceException commented on 682becf May 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just fixed this myself, took some time though to figure out, why this still isn't merged??
Also I wanted to submit a pull request with this, but the button is greyed out and I see a compare page for some reason.

@InFerNoBeasTz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this worked.

@ArtDor2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally found this fix! I tried using the thumbnail script in windows earlier but it did not work and I just gave up on it.

@paulo-caldas
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solved it for me, thank you! Please consider implementing in the latest release

@eug-vs
Copy link

@eug-vs eug-vs commented on 682becf Oct 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Please sign in to comment.