Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug of incorrect as_resizableRoundedImageWithCornerRadius background color. #1964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yingchenw
Copy link

The background in as_resizableRoundedImageWithCornerRadius is created using a stretchable image, whose center 1x1 area will be later stretched to fit the entire content area. However, the color of the center area may be affected by its nearby pixels. This can cause the image background area to have an incorrect background color.

This fix repaints the center 1x1 area with the fillColor specified by the user.

The background of ELMContainerNode is created using a stretchable image, whose center 1x1 area will be later stretched to fit the entire content area. However, the color of the center area may be affected by its nearby pixels. This can cause the ELMContainerNode background area to have an incorrect background color.

This fix repaints the center 1x1 area with the fillColor specified by the user.

Fix some scuba tests.

PRESUBMIT=passed
BUG=179428110
FIXED=179428110
R=ganjam,konnork,rdarquea,siyusong,wiseoldduck,xpingzhou
CC=jaceks,jayklub,yt-backstage+cl,yt-elements-eng+cl,yt-innertube-auto+changes,yt-ios-auto+cl,yt-ios-mainapp+cl,yt-reviewlog
APPROVED=ganjam,konnork,siyusong,wiseoldduck,xpingzhou
REQUIRED_REVIEW=1
DELTA_INCOMPLETE=9 (9 added, 0 deleted, 0 changed)
DELTA_BY_EXTENSION=mm=9
OCL=356320759
FIG_CHANGESET=48007cddc301578950ddb29df65e18635e753b51
FIG_WORKSPACE=yingchenw/1362:


P4 change: 358302665
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants