Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli overhaul: guest create,get,delete commands (partial basic tests) #207

Merged
merged 13 commits into from
Oct 20, 2022
Merged

Cli overhaul: guest create,get,delete commands (partial basic tests) #207

merged 13 commits into from
Oct 20, 2022

Conversation

Tinyblargon
Copy link
Collaborator

Another pull for #171

Work so far:

  • Added the commands for creating, deleting and retrieving the configuration of qemu and lxc guests.
  • Added TODO items to keep track of which commands have been migrated to the new cli.
  • Added basic test for Qemu creating, retrieving and destroying.
  • refactored some code to make the implementation more DRY (only refactored code that has tests).

Only some basic test for Qemu. No test for Lxc yet, Lxc relies on a template which we cant upload yet in an automated fashion.

@mleone87 mleone87 merged commit 82d6490 into Telmate:master Oct 20, 2022
frostyfab pushed a commit to frostyfab/proxmox-api-go that referenced this pull request Nov 17, 2023
@mleone87
Merge pull request Telmate#207 from Tinyblargon/CLI-Overhaul
6efe2d4 
Cli overhaul: guest create,get,delete commands (partial basic tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tinyblargon @mleone87