Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Reqest: New Cli #171

Open
Tinyblargon opened this issue Apr 27, 2022 · 2 comments
Open

Feature Reqest: New Cli #171

Tinyblargon opened this issue Apr 27, 2022 · 2 comments

Comments

@Tinyblargon
Copy link
Collaborator

In Tinyblargon/proxmox-api-go:CLI-Overhaul I have started working on a new CLI for the project using cobra. this library is commonly used to create a CLI in GO. it has build in features like "--help" making the project more accessible for new users.
The goal is to eventually replace the big switch statement in main with this new CLI.
The new CLI has to be enabled manually, this can be done by setting the environment variable "NEW_CLI" to "true".

Is this CLI rewrite usefull for the project?
If so should it be merged as one big pull request once the whole CLI is rewritten? Or create pull requests as i go?

@mleone87
Copy link
Collaborator

Is this CLI rewrite usefull for the project?

for sure! I think that this could be the v1.0.0 release of this project?

If so should it be merged as one big pull request once the whole CLI is rewritten? Or create pull requests as i go?

merging in a new branch could be an option too? When finished we can merge it into main

@ggongaware
Copy link
Member

Cobra looks like a good replacement to manage the CLI. It should give the opportunity for more test coverage which would help validate a release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants