feat: UUID rate semver FPF-14284 #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frbattid
requested changes
Apr 19, 2024
| @@ -22,12 +22,12 @@ protected void setBounds( | |||
|
|
|||
| public double randomLatitude() { | |||
| Random r = new Random(); | |||
| return bottomBound + (upperBound - bottomBound) * r.nextDouble(); | |||
| return -90 + r.nextInt(180) + r.nextDouble(); | |||
There was a problem hiding this comment.
¿No funcionaba el mecanismo anterior?
| @@ -24,10 +24,12 @@ public void shouldStringifyCorrectly() { | |||
| FeatureCollection featureCollection = createFeatureCollection(); | |||
| assertNotNull(featureCollection.toString()); | |||
| Gson gson = new Gson(); | |||
|
|
|||
| String fcollection = featureCollection.toString(); | |||
There was a problem hiding this comment.
No parece necesario sacarlo fuera, ¿no? Si se fuera a usar en otro sitio la variable, ahí sí.
| Point point4 = new Point(null, null, crs); | ||
| Point point5 = new Point(point4.latitude, null, crs); | ||
| Point point6 = new Point(null, point5.longitude, crs); | ||
| /* NOTE: The polygon is formed by 5 points due to geojson library */ |
There was a problem hiding this comment.
Es curioso que el .isValid() no permita "triángulos" (4 puntos, el primero coincidiendo con el último).
| } | ||
| i++; | ||
| } | ||
| throw new RuntimeException("Could not generate a valid MultiPolygon after 1000 attempts."); |
There was a problem hiding this comment.
¿Sabemos las iteraciones, en media, que esto suele tardar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The versión of spark-sdk will be update when new release version with new logical types will be published.