fix: generator constructor

Telefonica · Apr 16, 2024 · e86d525 · e86d525
1 parent b141aae
commit e86d525
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/app/src/main/java/io/confluent/avro/random/generator/Main.java b/app/src/main/java/io/confluent/avro/random/generator/Main.java
@@ -324,19 +324,25 @@ private static Generator getGenerator(String schema, String schemaFile) throws I
         return getGenerator(schema, schemaFile, Optional.empty(), Optional.empty());
     }
 
-    private static Generator getGenerator(String schema, String schemaFile, Optional<Double> malformedNotInformedRate, Optional<Double> malformedColumnRate) throws IOException {
+    private static Generator getGenerator(String schema, String schemaFile, Optional<Double> notInformedColumnRate, Optional<Double> malformedColumnRate) throws IOException {
         if (schema != null) {
             return new Generator.Builder().schemaString(schema)
                     .malformedColumnRate(malformedColumnRate)
+                    .notInformedColumnRate(notInformedColumnRate)
                     .build();
         } else if (!schemaFile.equals("-")) {
             return new Generator.Builder()
-                    .schemaFile(new File(schemaFile), malformedNotInformedRate.isPresent())
+                    .schemaFile(new File(schemaFile), notInformedColumnRate.isPresent())
                     .malformedColumnRate(malformedColumnRate)
+                    .notInformedColumnRate(notInformedColumnRate)
                     .build();
         } else {
             System.err.println("Reading schema from stdin...");
-            return new Generator.Builder().schemaStream(System.in).malformedColumnRate(malformedColumnRate).build();
+            return new Generator.Builder()
+                    .schemaStream(System.in)
+                    .malformedColumnRate(malformedColumnRate)
+                    .notInformedColumnRate(notInformedColumnRate)
+                    .build();
         }
     }
 

diff --git a/app/src/test/java/io/confluent/avro/random/generator/CustomExtensionsGeneratorTest.java b/app/src/test/java/io/confluent/avro/random/generator/CustomExtensionsGeneratorTest.java
@@ -104,9 +104,9 @@ record = (GenericRecord) generator.generate();
       }
     }
 
-    assertEquals("Wrong string distribution", 0.45, ((double) stringResults.size()) / 100, 0.1);
-    assertEquals("Wrong int distribution", 0.45, ((double) intResults.size()) / 100, 0.1);
-    assertEquals("Wrong not informed distribution", 0.1, ((double) notInformedResults.size()) / 100, 0.1);
+    assertEquals("Wrong string distribution", 0.45, ((double) stringResults.size()) / 100, 0.2);
+    assertEquals("Wrong int distribution", 0.45, ((double) intResults.size()) / 100, 0.2);
+    assertEquals("Wrong not informed distribution", 0.1, ((double) notInformedResults.size()) / 100, 0.2);
     assertNotEquals("Empty not informed values", notInformedResults.size(), 0);
   }