feature parity with legacy ytproxy #18
Conversation
|
@FireMasterK , I was rewriting the response in nginx with lua, to have the urls from proxy be prepended by the proxy path. but it was very slow and produced a lot of buffering, so having support for it directly in the proxy would be awesome. please, let me know what do you think of this feature thanks :) |
will you plan to release a separated docker image with that build? |
There could be an image with all build features. |
|
@FireMasterK fixed, pleae let me know if anything else is missing |
| @@ -46,12 +60,12 @@ fn finalize_url(path: &str, query: BTreeMap<String, String>) -> String { | |||
| if qhash.is_some() { | |||
| let mut query = QString::new(query.into_iter().collect::<Vec<_>>()); | |||
| query.add_pair(("qhash", qhash.unwrap())); | |||
| return format!("{}?{}", path, query); | |||
There was a problem hiding this comment.
We need feature specific code for when prefix-path enabled and not.
There was a problem hiding this comment.
hi @FireMasterK , please let me know if my solution is what you meant. thanks
PREFIX_PATHenv variable for special deployment case where the proxy is hosted behind a path rather on a separate domain