-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Update headers and style refactor #55
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Thierry Bugier <[email protected]>
Signed-off-by: Thierry Bugier <[email protected]>
this text is already in README.md Signed-off-by: Thierry Bugier <[email protected]>
Signed-off-by: Thierry Bugier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of files have the error_reporting forced, I think is better to centralize that and have it as an configuration argument or ENV value
@@ -48,8 +41,8 @@ | |||
namespace CFPropertyList; | |||
|
|||
// just in case... | |||
error_reporting( E_ALL ); | |||
ini_set( 'display_errors', 'on' ); | |||
error_reporting(E_ALL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really good to have this?....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are examples to show how to use the library. They must be as simple as possible, straightforward. For me this is fine.
Style fxes