Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ed25519 sign and verify test vectors #103

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Add Ed25519 sign and verify test vectors #103

merged 3 commits into from
Jan 15, 2024

Conversation

frankhinek
Copy link
Contributor

@frankhinek frankhinek commented Jan 12, 2024 •
edited
Loading

This PR will:

  • Add test vectors for Crypto - Ed25519 - sign and verify operations
  • Test vectors extracted from web5-js, where they are currently being used.
  • README includes a link to reference implementations of the functions being tested so that other SDK implementers can re-implement in other languages.

closes #85

@frankhinek frankhinek added test-harness crypto cryptographic primitives labels Jan 12, 2024
mistermoe
mistermoe approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@mistermoe mistermoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome

@frankhinek frankhinek merged commit 455df9a into main Jan 15, 2024
6 checks passed
@frankhinek frankhinek deleted the vector-crypto-ed25519 branch January 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistermoe mistermoe mistermoe approved these changes

@amika-sq amika-sq amika-sq approved these changes

@decentralgabe decentralgabe Awaiting requested review from decentralgabe decentralgabe is a code owner

@phoebe-lew phoebe-lew Awaiting requested review from phoebe-lew

Assignees
No one assigned
Labels
crypto cryptographic primitives
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Produce test vectors for Ed25519 signing and verification
3 participants
@frankhinek @mistermoe @amika-sq