Add secp256k1 signer & verifier, fix serde deserialize optional timestamp bug, add vc verify test vector #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
shamilovtim,
diehuxx,
frankhinek and
leordev
as code owners
KendallWeihe
commented
Sep 10, 2024
| @@ -22,13 +22,15 @@ pub struct JwtPayloadVerifiableCredential { | |||
| #[serde( | |||
| rename = "issuanceDate", | |||
| serialize_with = "serialize_optional_system_time", | |||
| deserialize_with = "deserialize_optional_system_time" | |||
| deserialize_with = "deserialize_optional_system_time", | |||
| default | |||
There was a problem hiding this comment.
this was that serde deserialize bug -- turns out if you bring a custom deserializer then the Option<T> doesn't pick it up so you have to make it explicit
nitro-neal
reviewed
Sep 10, 2024
| } | ||
|
|
||
| #[test] | ||
| fn verify() { |
nitro-neal
approved these changes
Sep 10, 2024
KendallWeihe
force-pushed
the
kendall/test-vec-cred-verify
branch
from
c52fe83
to
e0795cf
Compare
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to first merge this PR TBD54566975/web5-spec#173 and then update our web5-spec commitEdit: done