Decouple from UniFFI code-gen'd Web5Exception #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KendallWeihe
requested review from
nitro-neal,
kirahsapong,
shamilovtim,
diehuxx,
decentralgabe,
frankhinek,
leordev and
ALRubinger
as code owners
diehuxx
approved these changes
Sep 3, 2024
nitro-neal
reviewed
Sep 3, 2024
| enum class Dsa { | ||
| ED25519, | ||
| SECP256K1; | ||
| } | ||
|
|
||
| internal fun dsaFromRustCore(rustCore: RustCoreDsa): Dsa { |
nitro-neal
reviewed
Sep 3, 2024
| @@ -14,8 +16,14 @@ class Ed25519Generator { | |||
| * @return Jwk the JWK with private key material included. | |||
| */ | |||
| fun generate(): Jwk { | |||
There was a problem hiding this comment.
chad says:
You can simplify the generate() function by removing the redundant catch block for the generic Exception, as it will automatically be propagated if not caught.
There was a problem hiding this comment.
also since there are a lot of these it could be cleaner to do it this way with return try:
return try {
val rustCoreJwkData = ed25519GeneratorGenerate()
Jwk.fromRustCoreJwkData(rustCoreJwkData)
} catch (e: RustCoreException) {
throw Web5Exception.fromRustCore(e)
}
There was a problem hiding this comment.
nice catch! done
nitro-neal
reviewed
Sep 3, 2024
nitro-neal
approved these changes
Sep 3, 2024
|
added this issue to investigate further for less verbose exception handling - #335 |
KendallWeihe
force-pushed
the
kendall/decouple-uniffi-web5exception
branch
from
9d6d3b5
to
e484f59
Compare
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the last piece to completely decouple us from uniffi codegen at the api surface
also fixed the Dsa which was still a lingering coupling