Select Credentials #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
commented
May 3, 2024
| late List<SelectCredentialTestVector> vectors; | ||
|
|
||
| setUpAll(() { | ||
| final vectorsJson = getJsonVectors('presentation_exchange/select_credentials.json'); |
There was a problem hiding this comment.
running into trouble reading the vectors from the submodule. i'll take another stab at it in the morning
diehuxx
requested review from
mistermoe,
ethan-tbd,
kirahsapong and
wesbillman
as code owners
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
mistermoe
reviewed
May 4, 2024
packages/web5/lib/src/pexv2/pd.dart
Outdated
| selectionCandidate[tokenPath.token] = value; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
if this loop ends and no paths matched, there's no need to continue evaluating the current vcJwt
mistermoe
reviewed
May 4, 2024
mistermoe
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on ##52 and TBD54566975/web5-go#143
TODO: