Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated logging exporter #3052

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mistermoe
Copy link
Member

Summary

This PR replaces a deprecated logging exporter being used in the local otel collector causing it to bork on startup. replaced with debug exporter

closes #3019

Before

docker compose --profile infra up otel-collector
[+] Running 4/4
 ✔ otel-collector Pulled                                                                                                                               6.0s
   ✔ f269895151d7 Pull complete                                                                                                                        0.4s
   ✔ 5d76f70d74fd Pull complete                                                                                                                        4.3s
   ✔ f5b2992c14e2 Pull complete                                                                                                                        4.3s
[+] Running 1/1
 ✔ Container ftl-otel-collector-1  Recreated                                                                                                           0.3s
Attaching to otel-collector-1
otel-collector-1  | Error: failed to get config: cannot unmarshal the configuration: decoding failed due to the following error(s):
otel-collector-1  |
otel-collector-1  | error decoding 'exporters': the logging exporter has been deprecated, use the debug exporter instead
otel-collector-1  | 2024/10/09 14:20:57 collector server run finished with error: failed to get config: cannot unmarshal the configuration: decoding failed due to the following error(s):
otel-collector-1  |
otel-collector-1  | error decoding 'exporters': the logging exporter has been deprecated, use the debug exporter instead
otel-collector-1 exited with code 1

After

docker compose --profile infra up otel-collector
[+] Running 1/0
 ✔ Container ftl-otel-collector-1  Created                                                                                                             0.0s
Attaching to otel-collector-1
otel-collector-1  | 2024-10-09T14:22:14.184Z	info	[email protected]/service.go:136	Setting up own telemetry...
otel-collector-1  | 2024-10-09T14:22:14.184Z	info	telemetry/metrics.go:70	Serving metrics	{"address": "localhost:8888", "metrics level": "Normal"}
otel-collector-1  | 2024-10-09T14:22:14.184Z	info	builders/builders.go:26	Development component. May change in the future.	{"kind": "exporter", "data_type": "metrics", "name": "debug"}
otel-collector-1  | 2024-10-09T14:22:14.185Z	info	builders/builders.go:26	Development component. May change in the future.	{"kind": "exporter", "data_type": "traces", "name": "debug"}
otel-collector-1  | 2024-10-09T14:22:14.185Z	info	builders/builders.go:26	Development component. May change in the future.	{"kind": "exporter", "data_type": "logs", "name": "debug"}
otel-collector-1  | 2024-10-09T14:22:14.185Z	info	[email protected]/service.go:208	Starting otelcol-contrib...	{"Version": "0.111.0", "NumCPU": 10}
otel-collector-1  | 2024-10-09T14:22:14.185Z	info	extensions/extensions.go:39	Starting extensions...
otel-collector-1  | 2024-10-09T14:22:14.185Z	warn	[email protected]/warning.go:40	Using the 0.0.0.0 address exposes this server to every network interface, which may facilitate Denial of Service attacks.	{"kind": "receiver", "name": "otlp", "data_type": "traces", "documentation": "https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/security-best-practices.md#safeguards-against-denial-of-service-attacks"}
otel-collector-1  | 2024-10-09T14:22:14.185Z	info	[email protected]/otlp.go:112	Starting GRPC server	{"kind": "receiver", "name": "otlp", "data_type": "traces", "endpoint": "0.0.0.0:4317"}
otel-collector-1  | 2024-10-09T14:22:14.186Z	warn	[email protected]/warning.go:40	Using the 0.0.0.0 address exposes this server to every network interface, which may facilitate Denial of Service attacks.	{"kind": "receiver", "name": "otlp", "data_type": "traces", "documentation": "https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/security-best-practices.md#safeguards-against-denial-of-service-attacks"}
otel-collector-1  | 2024-10-09T14:22:14.186Z	info	[email protected]/otlp.go:169	Starting HTTP server	{"kind": "receiver", "name": "otlp", "data_type": "traces", "endpoint": "0.0.0.0:4318"}
otel-collector-1  | 2024-10-09T14:22:14.186Z	info	[email protected]/service.go:234	Everything is ready. Begin running and processing data.

@mistermoe mistermoe requested review from alecthomas and a team as code owners October 9, 2024 14:30
@mistermoe mistermoe requested review from deniseli and removed request for a team October 9, 2024 14:30
@ftl-robot ftl-robot mentioned this pull request Oct 9, 2024
@mistermoe mistermoe merged commit af833e1 into main Oct 9, 2024
98 checks passed
@mistermoe mistermoe deleted the moe/fix-local-otel-collector branch October 9, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

local otel collector is using deprecated exporter
2 participants