Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: query/path params only allow string #3049

Merged
merged 1 commit into from
Oct 9, 2024
Merged

fix: query/path params only allow string #3049

merged 1 commit into from
Oct 9, 2024
+170 −52

Conversation

stuartwdouglas
Copy link
Contributor

fixes: #3037

@stuartwdouglas stuartwdouglas requested review from alecthomas and a team as code owners October 9, 2024 03:59
@stuartwdouglas stuartwdouglas requested review from worstell and removed request for a team October 9, 2024 03:59
This was referenced Oct 9, 2024
Open
Open
wesbillman
wesbillman approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @stuartwdouglas

@wesbillman wesbillman merged commit 1a8e63b into main Oct 9, 2024
98 checks passed
@wesbillman wesbillman deleted the stuartwdouglas/3037 branch October 9, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesbillman wesbillman wesbillman approved these changes

@tomdaffurn tomdaffurn tomdaffurn approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@worstell worstell Awaiting requested review from worstell worstell is a code owner automatically assigned from TBD54566975/ftl-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update mangleQueryParameters to convert to underlying schema type instead of always strings
3 participants
@stuartwdouglas @wesbillman @tomdaffurn