chore: cancel context on signals #3042
Draft
+66
−216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // process group, and exits. | ||
| func RunWithSignalHandler(ctx context.Context, run func(ctx context.Context) error) error { | ||
| logger := log.FromContext(ctx) | ||
| ctx, stop := signal.NotifyContext(ctx, syscall.SIGINT, syscall.SIGTERM) |
There was a problem hiding this comment.
Doesn't the work around context cancellation happen asynchronously? Given that we immediately send SIGTERM won't it be non-deterministic as to which stuff actually sees the context cancellation?
There was a problem hiding this comment.
"run" won't return until it and all its child goroutines are complete, at which point there shouldn't be anything still running. This is actually an improvement on the previous behaviour, which listened for a signal and immediately ran kill + exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.