feat: Enums in JVM #2842
Open
feat: Enums in JVM #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdaffurn
requested review from
tlongwell-block and
worstell
and removed request for
a team
stuartwdouglas
approved these changes
Oct 9, 2024
| @@ -4,6 +4,9 @@ | |||
| import java.util.ArrayList; | |||
| import java.util.List; | |||
|
|
|||
| import org.slf4j.Logger; | |||
There was a problem hiding this comment.
This should be the jboss logger used by Quarkus (slf4j still works, but it delegates to JBoss logging under the hood).
|
|
||
| public class EnumProcessor { | ||
|
|
||
| private static final Logger log = LoggerFactory.getLogger(EnumProcessor.class); |
| @@ -26,6 +29,7 @@ public abstract class JVMCodeGenerator implements CodeGenProvider { | |||
|
|
|||
| public static final String PACKAGE_PREFIX = "ftl."; | |||
| public static final String TYPE_MAPPER = "TypeAliasMapper"; | |||
| private static final Logger log = LoggerFactory.getLogger(JVMCodeGenerator.class); | |||
|
|
||
| public class ModuleProcessor { | ||
|
|
||
| private static final Logger log = Logger.getLogger(ModuleProcessor.class); | ||
| private static final Logger log = LoggerFactory.getLogger(ModuleProcessor.class); |
|
|
||
| @Enum | ||
| public interface Animal { | ||
| @JsonIgnore |
There was a problem hiding this comment.
I wonder if we can eventually remove the need for these annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2514
Tasks: