chore: remove Future.microtask() use (#264)

TBD54566975 · Aug 15, 2024 · ba16924 · ba16924
1 parent 6f00a1f
commit ba16924
Show file tree

Hide file tree

Showing 14 changed files with 31 additions and 11 deletions.
diff --git a/lib/features/account/account_balance_card.dart b/lib/features/account/account_balance_card.dart
@@ -27,7 +27,8 @@ class AccountBalanceCard extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(
+        Future.delayed(
+          Duration.zero,
           () async => getAccountBalanceNotifier()
               .startPolling(ref.read(didProvider), pfis),
         );

diff --git a/lib/features/dap/dap_qr_tile.dart b/lib/features/dap/dap_qr_tile.dart
@@ -22,7 +22,8 @@ class DapQrTile extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(
+        Future.delayed(
+          Duration.zero,
           () async => isPhysicalDevice.value =
               await ref.read(deviceInfoServiceProvider).isPhysicalDevice(),
         );

diff --git a/lib/features/did/did_qr_tile.dart b/lib/features/did/did_qr_tile.dart
@@ -23,7 +23,8 @@ class DidQrTile extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(
+        Future.delayed(
+          Duration.zero,
           () async => isPhysicalDevice.value =
               await ref.read(deviceInfoServiceProvider).isPhysicalDevice(),
         );

diff --git a/lib/features/home/home_page.dart b/lib/features/home/home_page.dart
@@ -25,7 +25,8 @@ class HomePage extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(() async => _getExchanges(context, ref, exchanges));
+        Future.delayed(
+            Duration.zero, () async => _getExchanges(context, ref, exchanges),);
         return null;
       },
       [],

diff --git a/lib/features/kcc/kcc_retrieval_page.dart b/lib/features/kcc/kcc_retrieval_page.dart
@@ -28,7 +28,8 @@ class KccRetrievalPage extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(
+        Future.delayed(
+          Duration.zero,
           () async => _pollForCredential(context, ref, credential),
         );
 

diff --git a/lib/features/kcc/kcc_webview_page.dart b/lib/features/kcc/kcc_webview_page.dart
@@ -37,7 +37,8 @@ class KccWebviewPage extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(
+        Future.delayed(
+          Duration.zero,
           () async => _loadWebView(context, ref, idvRequest, webViewController),
         );
         return null;

diff --git a/lib/features/payment/payment_amount_page.dart b/lib/features/payment/payment_amount_page.dart
@@ -41,8 +41,9 @@ class PaymentAmountPage extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(
-          () async => _getOfferings(context, ref, offerings),
+        Future.delayed(
+          Duration.zero,
+          () => _getOfferings(context, ref, offerings),
         );
         return null;
       },

diff --git a/lib/features/payment/payment_fetch_instructions_widget.dart b/lib/features/payment/payment_fetch_instructions_widget.dart
@@ -32,7 +32,7 @@ class PaymentFetchInstructionsWidget extends HookWidget {
 
     useEffect(
       () {
-        Future.microtask(() async {
+        Future.delayed(Duration.zero, () async {
           if (context.mounted) {
             await _pollForInstructions(context, ref, getInstructionsNotifier());
           }

diff --git a/lib/features/payment/payment_fetch_quote_widget.dart b/lib/features/payment/payment_fetch_quote_widget.dart
@@ -29,7 +29,7 @@ class PaymentFetchQuoteWidget extends HookWidget {
 
     useEffect(
       () {
-        Future.microtask(() async {
+        Future.delayed(Duration.zero, () async {
           if (context.mounted) {
             await _pollForQuote(context, ref, getQuoteNotifier());
           }

diff --git a/lib/features/transaction/transaction_tile.dart b/lib/features/transaction/transaction_tile.dart
@@ -31,7 +31,10 @@ class TransactionTile extends HookConsumerWidget {
 
     useEffect(
       () {
-        Future.microtask(() async => getTransactionsNotifier().startPolling());
+        Future.delayed(
+          Duration.zero,
+          () async => getTransactionsNotifier().startPolling(),
+        );
         return getTransactionsNotifier().stopPolling;
       },
       [],

diff --git a/test/features/app/app_tabs_test.dart b/test/features/app/app_tabs_test.dart
@@ -61,6 +61,7 @@ void main() async {
 
     testWidgets('should start on HomePage', (tester) async {
       await tester.pumpWidget(appTabsTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.byType(HomePage), findsOneWidget);
     });

diff --git a/test/features/home/home_page_test.dart b/test/features/home/home_page_test.dart
@@ -73,6 +73,7 @@ void main() async {
 
     testWidgets('should show account balance', (tester) async {
       await tester.pumpWidget(homePageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.text('Account balance'), findsOneWidget);
     });
@@ -87,12 +88,14 @@ void main() async {
 
     testWidgets('should show deposit button', (tester) async {
       await tester.pumpWidget(homePageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.widgetWithText(FilledButton, 'Deposit'), findsOneWidget);
     });
 
     testWidgets('should show withdraw button', (tester) async {
       await tester.pumpWidget(homePageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.widgetWithText(FilledButton, 'Withdraw'), findsOneWidget);
     });

diff --git a/test/features/pfis/pfis_add_page_test.dart b/test/features/pfis/pfis_add_page_test.dart
@@ -13,6 +13,7 @@ void main() {
 
     testWidgets('should show QR Code CTA', (tester) async {
       await tester.pumpWidget(pfisAddPageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(
         find.widgetWithText(
@@ -25,12 +26,14 @@ void main() {
 
     testWidgets('should show input field', (tester) async {
       await tester.pumpWidget(pfisAddPageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.byType(TextField), findsOneWidget);
     });
 
     testWidgets('should show add button', (tester) async {
       await tester.pumpWidget(pfisAddPageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.widgetWithText(FilledButton, 'Add'), findsOneWidget);
     });

diff --git a/test/features/send/send_page_test.dart b/test/features/send/send_page_test.dart
@@ -31,6 +31,7 @@ void main() async {
 
     testWidgets('should show QR Code CTA', (tester) async {
       await tester.pumpWidget(sendDetailsPageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(
         find.widgetWithText(
@@ -43,12 +44,14 @@ void main() async {
 
     testWidgets('should show input field', (tester) async {
       await tester.pumpWidget(sendDetailsPageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.byType(TextField), findsOneWidget);
     });
 
     testWidgets('should show next button', (tester) async {
       await tester.pumpWidget(sendDetailsPageTestWidget());
+      await tester.pumpAndSettle();
 
       expect(find.widgetWithText(FilledButton, 'Next'), findsOneWidget);
     });