Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore sampler warnigns caused by paramters outside the parameter limits #137

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

kaiserls
Copy link
Collaborator

@kaiserls kaiserls commented Sep 8, 2024

Description

EPI currently sets the log probability of a parameter point to -inf when the model is evaluated outside the parameter range limits. This leads to a large number of warning messages from the emcee mcmc sampler when a move leaves the parameter range. Warnings resulting from the subtraction of -inf in the red_blue move scheme are suppressed by this pull request. Other warning and error messages are not affected by this pull request.

Type of change

Please tick at least one of the options. Delete the other options.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Confirmed manually that the specific warning messages disappear and other warnings are unaffected

Checklist For Contributor

  • My code follows the style guidelines of this project (I installed pre-commit)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote my changes in the changelog in the [unreleased] section
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Checklist For Maintainers

  • Continuous Integration (CI) is successfully running
  • Do we want to release/tag a new version? [✔️ / ❌]
    • If yes, add a release to the changelog and set the new version in pyproject.toml. After the merge, tag the release!

@kaiserls kaiserls merged commit 9f65fa0 into main Sep 8, 2024
2 checks passed
@kaiserls kaiserls deleted the fix/ignore_parameterrange_warnings branch September 8, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant