Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep track of kcat curations #385

Merged
merged 6 commits into from
Jul 31, 2024
Merged

feat: keep track of kcat curations #385

merged 6 commits into from
Jul 31, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jul 17, 2024

Main improvements in this PR:

  • Features:
    • If sensitivityTuning modifies a kcat value, it will now be indicated in model.ec.source as 'sensitivityTuning', and the previous kcat value and source will be kept in the model.ec.notes field as preTuneKcat=*value* | source:*original source*. If the kcat value had been subjected to senstivityTuning before, then the notes field will remain unchanged, so repeated runs of sensitivityTuning will not overwrite the notes.
  • Fix:
    • By default, the obj.params.uniprot.reviewed parameter in the adapterTemplate is set to false, to increase the number of matching proteins.
    • The model.ec.source entry after running setKcatForReactions has been corrected to 'setKcatForReactions'.
  • Documentation:

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

Copy link

github-actions bot commented Jul 17, 2024

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
GECKO installed, unknown version (cannot find version.txt).
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 079ae8b into develop Jul 31, 2024
1 check passed
@mihai-sysbio mihai-sysbio deleted the feat/preTuneKcat branch August 27, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant