-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: loadDatabases check for duplicate protIDs #349
Conversation
This PR has been automatically tested with GH Actions. Here is the output of the tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be good print the list of duplicated entries ?
It prints the Uniprot IDs. If you duplicate the first entry in uniprot.tsv, the error message is:
|
True! I misunderstood the final part of the code. |
* fix: loadDatabases check for duplicate protIDs (#349) * fix: prevent NaN in light ecModels (#346) * fix: calculateFfactor if paxDB has taxID !4 chars (#347) * fix: runDLKcat if path has spaces (#352) * refactor: FSEOF (#356) * fix: FSEOF to 0.9 of teorethical max prod * refactor: switch force objetive to target * fix: remove unnecesary function * fix: update input arguments * fix: temporal solution k-score * refactor: FSEOF * feat: add gene essentiality to FSEOF * fix: file writing * feat: add cutoff based on quantile * feat: report target transport reactions * refactor: add cutoff for essentiality * fix: bug identifying gene essentiality * doc: move installations instructions to wiki (#357) * move installation instructions to wiki * GECKOInstaller checks for latest GECKO version * fix: prevent duplications in protein pseudometabolites * minor fixes * doc: update documentation * doc: swap gitter for GitHub Discussions * fix: correct link to upgrade instructions * fix: synchronize STEP numbers protocol and paper --------- Co-authored-by: Albert Tafur Rangel <[email protected]>
Main improvements in this PR:
loadDatabases
throws error if duplicate protein IDs are foundInstructions on merging this PR:
develop
as target branch, and will be resolved with a squash-merge.main
as target branch, and will be resolved with a merge commit.