Small non-breaking fixes, PSR formatted code, merged many other branches. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt to GifCreator namespace * Frame interval is in centiseconds, not milliseconds
browsers seem to interpret this differently. Chrome will play animation twice while Firefox will play animation once. To work around this strangeness we can remove the loop count completely from the GIF and this seems to be interpreted as "play once only" by all browsers.
it was not defined
so it REALLY reset frameSources, and doesnt break when you call create() multiple times (as in a loop)
$mode removed
$this->frameSources=[];
Merging test by bosz
# Conflicts: # src/GifCreator/GifCreator.php
zoransa
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporated many of the other pull requests, reformatted code for PSR-standards. Fixed some small warnings/notices.