feat: Allow db common to be hardcoded #3706
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the db common to be hardcoded in the value file. For instance, it will allow idempotence Signed-off-by: Julien Godin <[email protected]>
JGodin-C2C
had a problem deploying
to
ci-renku-3706
GitHub Actions
Failure
|
@aledegano I also doing some stuff here 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This allows the db common to be hardcoded in the value file. For instance, it will allow idempotence
why
This will solve a problem met when using, for example, sealed secret
Further thought
I am not sure if this is a good idea, or if one should remove the whole secret management when a secret is provided by the user and let the user manage the secret by himself, leading to a more flexible way of managing this particular secret.