Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefer RS256 for JWT validation #3695

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

fix: prefer RS256 for JWT validation #3695

wants to merge 3 commits into from

Conversation

olevski
Copy link
Member

@olevski olevski commented Jan 25, 2024 •
edited
Loading

This removes some unused old code that is not needed and adds JWT validation with RS256.

It is part of the gateway refactoring.

Still WIP.

@olevski olevski requested a review from a team as a code owner January 25, 2024 14:35
@olevski olevski marked this pull request as draft January 25, 2024 14:35
@coveralls
Copy link
Collaborator

coveralls commented Jan 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7660443831

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-6.7%) to 78.505%
Totals Coverage Status
Change from base Build 7584575825: -6.7%
Covered Lines: 24543
Relevant Lines: 31263
💛 - Coveralls

@olevski olevski force-pushed the fix--use-RS256-for-token-validation branch 6 times, most recently from 0b5f406 to 23edee2 Compare January 25, 2024 17:11
@olevski olevski force-pushed the fix--use-RS256-for-token-validation branch from 4ad0354 to c93d276 Compare January 25, 2024 20:06
@olevski olevski force-pushed the fix--use-RS256-for-token-validation branch from c93d276 to e3bb052 Compare January 25, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation:pending
Projects
renku-python
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olevski @coveralls