WIP: Streamline simulation in preparation for new features #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Import G4 component of Bayeux.mctools from upstream develop branch at commit: BxCppDev/Bayeux@8a73b9b Provide basic build as single library.
Check and fix the clang-tidy recommendations detected by: -checks=-*,readability-*,modernize-*,performance-* This is purely to record the automatic fixes, additional review/style or revertion in additional commits.
Pure name change to allow comparison with mctools::g4 without clashes. However, note that resource files are also changed in one minor way.
Avoids masking/using any existing mctools/g4 headers in include path.
drbenmorgan
force-pushed
the
simulation-module
branch
from
6b54529
to
cf38e71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To assist in addressing feature requests #176, #178, the outcome of #188, and allow simulation to be run as a true pipeline module, implement this module in Falaise based on the latest mctools/g4 module from Bayeux. At present, this PR simply:
mctools::g4.flsimulateand resource file to use thesnsimnamespace.That will be the only change addressed by this PR so that we can validate that this introduces no physics changes. It's being submitted as a WIP/Draft to check compilation on our supported platforms and the usual "early eyes". I'll run a basic series of 82Se jobs using the
developof Falaise and theHEADof this PR to confirm that no (non-statistical) changes are introduced.