Add Stripe Webhook logic to retrieve payment intent events, and add to Payment entity valid status and description #57

Reyzis2021 · 2023-07-23T11:54:46Z

Changes:

A complete refactoring was carried out throughout the entire payment API, the code was adapted to the architecture and requirements of the project, it was also rewritten using SOLID principles, for greater frequency and improved code readability.
Added a new payment endpoint method paymentEventsProcess(/api/v1/payment/event ), as well as end to end business logic for it, edit table in liquibase, logic for processing events that are passed to us as input, repository, etc.
Added java docks for classes using the Stripe API, for a better understanding of what is happening in them.
Added a handler to execute different scenarios based on the type of event.
Added permission to the spring security configuration for this endpoint to avoid blocking work with the stripe remotely and its resources.

Test: At the moment, we don't have stripe logic on the frontend side yet. You have to generate events yourself, using Stripe SLI. And check how events are caught, and how, based on this, this or that logic works, which is intended to be executed in response to an event. The application rises, the endpoint has been tested. I will try to describe in detail how to test this logic in the Trello ticket.

…o Payment entity valid status and description

src/main/java/com/zufar/onlinestore/payment/PaymentApi.java

src/main/java/com/zufar/onlinestore/payment/processor/PaymentProcessor.java

src/main/java/com/zufar/onlinestore/payment/config/StripeConfiguration.java

src/main/java/com/zufar/onlinestore/payment/model/Payment.java

src/main/java/com/zufar/onlinestore/payment/processor/PaymentEventProcessor.java

src/main/java/com/zufar/onlinestore/payment/service/impl/PaymentEventServiceImpl.java

src/main/java/com/zufar/onlinestore/payment/processor/PaymentEventProcessor.java

src/main/java/com/zufar/onlinestore/payment/processor/PaymentProcessor.java

src/main/java/com/zufar/onlinestore/payment/service/impl/PaymentEventServiceImpl.java

# Conflicts: # src/main/java/com/zufar/onlinestore/payment/PaymentApi.java # src/main/java/com/zufar/onlinestore/payment/config/StripeConfiguration.java # src/main/java/com/zufar/onlinestore/payment/dto/PaymentDetailsDto.java # src/main/java/com/zufar/onlinestore/payment/dto/PaymentWithTokenDetailsDto.java # src/main/java/com/zufar/onlinestore/payment/processor/PaymentProcessor.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentGetter.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentCreator.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentEventParser.java

src/main/java/com/zufar/onlinestore/payment/controller/PaymentController.java

src/main/java/com/zufar/onlinestore/payment/dto/CreatePaymentMethodDto.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentIntentCreator.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentMethodGetter.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentGetter.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentMethodGetter.java

src/main/java/com/zufar/onlinestore/payment/api/PaymentApi.java

src/main/java/com/zufar/onlinestore/payment/api/impl/PaymentApiImpl.java

Sunagatov · 2023-07-27T00:38:48Z

src/main/java/com/zufar/onlinestore/payment/entity/Payment.java

@@ -25,15 +30,38 @@ public class Payment {
    @Column(name = "payment_id")
    private Long paymentId;

+    @Column(nullable = false, unique = true, name = "payment_intent_id")


fix it please

src/main/java/com/zufar/onlinestore/payment/repository/PaymentRepository.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentEventProcessor.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentFailedScenarioHandler.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentIntentCreator.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentMethodCreator.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentRetriever.java

src/main/java/com/zufar/onlinestore/payment/service/PaymentSuccessfulScenarioHandler.java

yevr19 · 2023-07-27T12:33:18Z

src/main/java/com/zufar/onlinestore/payment/api/PaymentApi.java

+     * @param stripeSignatureHeader this param it is a string describing of the stripe signature, which provide safe work with Stripe API webhooks mechanism
+     * @throws SignatureVerificationException this exception throw then stripe signature verification problem was occurred
+     * */
+    void paymentEventProcess(final String paymentIntentPayload, final String stripeSignatureHeader) throws SignatureVerificationException;


processPaymentEvent *

yevr19 · 2023-07-27T12:35:07Z

src/main/java/com/zufar/onlinestore/payment/config/StripeConfiguration.java


    @PostConstruct
    private void init() {
        Stripe.apiKey = secretKey;
    }
+


probably remove extra space here

yevr19 · 2023-07-27T12:43:28Z

src/main/java/com/zufar/onlinestore/payment/endpoint/PaymentEndpoint.java

+    public ResponseEntity<Void> paymentEventsProcess(
+            @RequestBody @Valid @NotEmpty String paymentIntentPayload,
+            @RequestHeader("Stripe-Signature") @Valid @NotEmpty String stripeSignatureHeader) throws SignatureVerificationException {
+        if (Objects.isNull(paymentIntentPayload) || Objects.isNull(stripeSignatureHeader)) {


constrained with @notempty must be not null, and its size/length must be greater than zero.

I dont see so much sense to put additional if checks for it

Add @NotNull constraint, but NotEmpty annotation validate that string must be not null, and its size/length must be greater than zero, adding @SiZe doesnt make sense

yevr19 · 2023-07-27T12:45:58Z

src/main/java/com/zufar/onlinestore/payment/entity/Payment.java

@@ -25,15 +30,38 @@ public class Payment {
    @Column(name = "payment_id")
    private Long paymentId;

+    @Column(nullable = false, unique = true, name = "payment_intent_id")


yevr19 · 2023-07-27T12:49:59Z

src/main/java/com/zufar/onlinestore/payment/service/scenario/PaymentFailedScenarioHandler.java

+        Payment updatedPayment = paymentRepository.updateStatusAndDescriptionInPayment(
+                paymentIntent.getId(), status, status.getDescription());
+        log.info("Handle payment scenario method: finish of handling payment intent: {} by failed scenario.", paymentIntent);
+        log.debug("Handle payment scenario method: payment data was updated: {}.", updatedPayment);


please remove

yevr19 · 2023-07-27T12:51:25Z

...in/java/com/zufar/onlinestore/payment/service/scenario/PaymentSuccessfulScenarioHandler.java

+                paymentIntent.getId(), status, status.getDescription());
+        log.info("Handle payment scenario method: finish of handling payment intent: {} by successful scenario.", paymentIntent);
+        log.debug("Handle payment scenario method: payment data was updated: {}.", updatedPayment);
+    }


please remove

…nt-handling-logic-was-added

Add Stripe Webhook logic to retrieve payment intent events, and add t…

40c9537

…o Payment entity valid status and description

Sunagatov reviewed Jul 23, 2023

View reviewed changes

yevr19 reviewed Jul 23, 2023

View reviewed changes

Reyzis2021 added 2 commits July 24, 2023 14:54

Сompleted refactoring was made according to the comments

aa727ce

yevr19 reviewed Jul 24, 2023

View reviewed changes

Sunagatov reviewed Jul 24, 2023

View reviewed changes

Finished full payment API according to the review comments

7d1c2e1

Sunagatov reviewed Jul 27, 2023

View reviewed changes

Added java docs

0819a9e

Sunagatov approved these changes Jul 27, 2023

View reviewed changes

yevr19 reviewed Jul 27, 2023

View reviewed changes

Reyzis2021 added 4 commits July 27, 2023 23:31

Final refactoring done

871bb98

add new request matcher for WEBHOOK_PAYMENT_EVENT_ENDPOINT

67d3732

add additional fixes according to comments from review

5afc333

Merge branch 'development' into feature/Payment-6

2e1eabd

Sunagatov approved these changes Jul 28, 2023

View reviewed changes

Reyzis2021 added 2 commits July 28, 2023 16:35

remove duplicate ;

f2e5c51

Merge branch 'development' into feature/Payment-6/webhook-payment-eve…

cb2f2f4

…nt-handling-logic-was-added

yevr19 approved these changes Jul 28, 2023

View reviewed changes

Sunagatov merged commit f85781c into Sunagatov:development Jul 28, 2023
1 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Stripe Webhook logic to retrieve payment intent events, and add to Payment entity valid status and description #57

Add Stripe Webhook logic to retrieve payment intent events, and add to Payment entity valid status and description #57

Reyzis2021 commented Jul 23, 2023 •

edited

Loading

Sunagatov Jul 27, 2023

yevr19 Jul 27, 2023

Reyzis2021 Jul 27, 2023

yevr19 Jul 27, 2023

Reyzis2021 Jul 27, 2023

yevr19 Jul 27, 2023

Reyzis2021 Jul 27, 2023

yevr19 Jul 27, 2023

yevr19 Jul 27, 2023

Reyzis2021 Jul 27, 2023

yevr19 Jul 27, 2023

Reyzis2021 Jul 27, 2023

Add Stripe Webhook logic to retrieve payment intent events, and add to Payment entity valid status and description #57

Add Stripe Webhook logic to retrieve payment intent events, and add to Payment entity valid status and description #57

Conversation

Reyzis2021 commented Jul 23, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Reyzis2021 commented Jul 23, 2023 •

edited

Loading