Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make running forks a bit easier #693

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jukie
Copy link

@jukie jukie commented Apr 25, 2024

This is to make it easier to run a fork with limited changes to the github actions.

  • Splits up jobs so if a user doesn't have ECR configured for example the others can still execute
  • Allows for setting OVERRIDE_ image tags at the repo level so a fork user can push to their own registries.

For context I'm changing the output format in the fluent plugin like this but would still like to have an easy process for syncing the fork without dealing with conflicts every time.

@jukie jukie requested a review from a team as a code owner April 25, 2024 15:37
@swiatekm
Copy link

Would it also help to make the jobs conditional on the required secrets existing?

I'm ok with this change overall, but I don't like duplicating the tag extraction logic in each job. Could we move that to a separate job that the rest can depend on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants