Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scripts/install.sh): check config path permissions and ownership #819

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

swiatekm
Copy link

@swiatekm swiatekm commented Nov 7, 2022

This partially resolves #817

@swiatekm swiatekm requested a review from a team as a code owner November 7, 2022 11:25
@github-actions github-actions bot added the go label Nov 7, 2022
Copy link
Contributor

@sumo-drosiek sumo-drosiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

btw, I was thinking about chaining checks, as some checks require the other one. e.g. checking configuration requires configuration file to exists. I believe it would make tests a bit more cleaner

@swiatekm
Copy link
Author

swiatekm commented Nov 7, 2022

LGTM

btw, I was thinking about chaining checks, as some checks require the other one. e.g. checking configuration requires configuration file to exists. I believe it would make tests a bit more cleaner

Chaining, as in, how exactly would that look? The problem with config files specifically is that the script doesn't touch existing ones, so if you set them up outside of the script, the permissions will stay as they are. That's why I didn't simply make the permissions check part of the existence check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file permission and ownership tests for install script
2 participants