Add remotely managed, ephemeral and api options to Windows install script/installer #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remotely managed * ephemeral * api
* unit tests * remove code warnings from C# code
packaging/msi/SumoLogic.wixext/SumoLogicTests/ConfigUpdaterTests.cs
Outdated
Show resolved
Hide resolved
* fix build error * add changelog entry
* fix test error * add validation for empty opamp folder when remotely managed * more opamp tests
* added tests for ephemeral and api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add the following options to the Windows install script and installer.
-RemotelyManaged- creates the OpAmp configuration items in sumologic.yaml-Ephemeral- sets the ephemeral option to the sumologic extension-Api- sets the api_base_url in the sumologic extension (used to run on staging)In addition to changing those options the service command line parameters are also different if the collector is remotely managed. It uses the
--remote-configoption instead of-confif.Testing has been performed on a Windows Server 2022 instance on AWS with a permutation of the different options to make sure that both the service parameters and configuration files are correct.
Note that a different PR adds support for the
--remotely-managedparameter for Windows services, which handles the startup arguments differently.