Handle DeletedFinalStateUnknown events form cache #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kruse <[email protected]>
Signed-off-by: Christian Kruse <[email protected]>
github-actions
bot
added
the
documentation
Comment on lines
+205
to
+208
| c.logger.Error( | ||
| "object received was DeletedFinalStateUnknown but did not contain api_v1.Pod", | ||
| zap.Any("received", obj), | ||
| ) |
There was a problem hiding this comment.
is it logged often? We would like to avoid extensive error logging if this may be expected behavior
There was a problem hiding this comment.
If I understand correctly, this is more of a sanity check that shouldn't trigger an error in normal situation, as by design the cache.DeletedFinalStateUnknown event should contain the object it pertains to.
There was a problem hiding this comment.
I needed to double check if this function should always get pod object and confirm that observer is run per object type
andrzej-stencel
approved these changes
Oct 11, 2023
sumo-drosiek
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1277