Reuse compression configuration from the confighttp helper (#1432)

* Use the upstream compression module, which includes zstd support * Remove CompressEncoding * Remove local compression modules * Enable gzip compression by default * Adding a changelog * docs(exporter): Readme change * Only allow sumo supported compression encoding configuration * Deprecation notice for compress_encoding and test additions * Add validation to the deprecated CompressEncoding field to not support zstd * Use the upstream constants for compression types
SumoLogic · Feb 7, 2024 · 11f9ba2 · 11f9ba2
1 parent 81e94c0
commit 11f9ba2
Show file tree

Hide file tree

Showing 13 changed files with 171 additions and 579 deletions.
diff --git a/.changelog/1432.changed.txt b/.changelog/1432.changed.txt
@@ -0,0 +1 @@
+feat(sumologicexporter): Deprecate compress_encoding and remove all of our own compression code in favor of using the confighttp helper
diff --git a/otelcolbuilder/cmd/testdata/filelog_reallife_complicated_sumologicexporter.yaml b/otelcolbuilder/cmd/testdata/filelog_reallife_complicated_sumologicexporter.yaml
@@ -623,7 +623,7 @@ receivers:
 exporters:
   sumologic/1:
     endpoint: http://dummy.endpoint.com
-    compress_encoding: ""
+    compression: ""
     retry_on_failure:
       enabled: false
     sending_queue:

diff --git a/pkg/exporter/sumologicexporter/README.md b/pkg/exporter/sumologicexporter/README.md
@@ -17,7 +17,10 @@ exporters:
     # if sumologicextension is not being used, the endpoint is required
     endpoint: <HTTP_Source_URL>
     # Compression encoding format, empty string means no compression, default = gzip
+    # DEPRECATION NOTICE: compress_encoding (reason: use compression)
     compress_encoding: {gzip, deflate, ""}
+    # Compression encoding format, empty string means no compression, default = gzip
+    compression: {gzip, zstd, deflate, ""}
     # max HTTP request body size in bytes before compression (if applied),
     # NOTE: this limit does not apply to data sent in otlp format,
     #   to limit size of otlp requests, please use the batch processor:

diff --git a/pkg/exporter/sumologicexporter/compress.go b/pkg/exporter/sumologicexporter/compress.go
diff --git a/pkg/exporter/sumologicexporter/compress_test.go b/pkg/exporter/sumologicexporter/compress_test.go